Skip to content

[None][infra] Drop jupyter-server from dockerfile.#13914

Open
tfogal wants to merge 1 commit intoNVIDIA:mainfrom
tfogal:tfogal/jupyter-server
Open

[None][infra] Drop jupyter-server from dockerfile.#13914
tfogal wants to merge 1 commit intoNVIDIA:mainfrom
tfogal:tfogal/jupyter-server

Conversation

@tfogal
Copy link
Copy Markdown

@tfogal tfogal commented May 8, 2026

jupyter-server requires nbconvert so when we drop nbconvert we end up breaking pip's dependency tracking/resolution. So let's just remove jupyter-server as well; we don't need it either.

Summary by CodeRabbit

  • Chores
    • Updated Docker development environment build configuration to adjust Python package handling during the container build process.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

jupyter-server requires nbconvert so when we drop nbconvert we end
up breaking pip's dependency tracking/resolution. So let's just
remove jupyter-server as well; we don't need it either.

Signed-off-by: Tom Fogal <60981+tfogal@users.noreply.github.com>
@tfogal tfogal requested review from a team as code owners May 8, 2026 18:38
@tfogal tfogal requested review from EmmaQiaoCh and mlefeb01 May 8, 2026 18:38
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 578f2284-2eb1-4afc-9e5c-a26ec8228301

📥 Commits

Reviewing files that changed from the base of the PR and between c87f002 and 9e838e9.

📒 Files selected for processing (1)
  • docker/Dockerfile.multi

📝 Walkthrough

Walkthrough

The pull request updates the devel stage of docker/Dockerfile.multi. The dependency-uninstall "WAR" step now removes jupyter-server from the Python environment and reorders the removal of NVIDIA CUTLASS packages alongside numpy, with the comment text updated to reflect this change.

Changes

Docker Dependency Configuration

Layer / File(s) Summary
Dependency Uninstall Configuration
docker/Dockerfile.multi
The pip3 uninstall -y command in the devel stage now includes jupyter-server and reorders the removal of nvidia-cutlass-dsl, nvidia-cutlass-dsl-libs-base, and numpy packages; accompanying comment updated accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description provides the rationale for the change (jupyter-server dependency conflict with nbconvert removal) but lacks Test Coverage and PR Checklist sections required by the template. Add Test Coverage section explaining how this change is validated, and ensure the PR Checklist is properly completed with actual checkboxes marked.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely summarizes the main change: removing jupyter-server from the Dockerfile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant