[https://nvbugs/6104831][draft] PR 13713 rebased onto v1.3.0rc13 — v7#13913
Draft
yifjiang wants to merge 9 commits intoNVIDIA:mainfrom
Draft
[https://nvbugs/6104831][draft] PR 13713 rebased onto v1.3.0rc13 — v7#13913yifjiang wants to merge 9 commits intoNVIDIA:mainfrom
yifjiang wants to merge 9 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
…disagg cancellation. Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> (cherry picked from commit 944561d)
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> 1777930306 -0700
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> # Conflicts: # tensorrt_llm/_torch/pyexecutor/py_executor.py
…transfer Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
svc-trtllm-gh-bot
added
the
Community want to contribute
…state to Python Adds public accessors `isRecvPoolPoisoned()` / `isSendPoolPoisoned()` on BaseTransBufferManager and BaseCacheTransceiver, surfacing the existing `ConcurrenceResource::mPoisoned` flag. Once any underlying pool's mPoisoned flag is set, BaseTransBufferManager:: assignBufferIndex throws unconditionally for the lifetime of the process (see baseTransBuffer.cpp:350 and the matching message: "The process must restart before these memory ranges can be safely reused"). Until now the only signal surfaced to callers was a per-request RequestError carrying the C++ exception text, which forces higher layers to string-match the message to distinguish a permanent worker-fatal state from genuinely transient per-request KV-transfer errors. This commit gives Python (the dynamo request handler / readiness probe) a structured, contract-stable way to ask "is this worker still able to serve disagg KV transfers, or must it be restarted?" without parsing error strings. Changes: - baseTransBuffer.h: two inline `noexcept` accessors that read the per-direction `mPoisoned` atomics (relaxed load mirrors the producer in poisonBufferIndex). - cacheTransceiver.h: virtual `isRecvPoolPoisoned()` / `isSendPoolPoisoned()` on BaseCacheTransceiver with a `return false` default so non-disagg subclasses (test mocks, generation-first Python transceiver) need not override. CacheTransceiver overrides walk the KV + RNN buffer-manager pointers and OR the per-manager state. - nanobind: bind the two methods on BaseCacheTransceiver. No trampoline size change required (defaults are concrete). - _torch/pyexecutor/kv_cache_transceiver.py: matching `is_recv_pool_poisoned` / `is_send_pool_poisoned` on the Python ABC (default False) and delegating implementations on `BindKvCacheTransceiver`. - tests/unittest/others/test_kv_cache_transceiver.py: regression test asserting both accessors return False on a fresh transceiver pair (NIXL + UCX backends). Signed-off-by: Yifan Jiang <19356972+yifjiang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of PR #13713 rebased onto v1.3.0rc13, branched off PR #13727's HEAD
66746088bfor additional iteration.Same 8 commits as PR #13713 (HEAD
5719008e22ec6b5fa6612525c556802ce593f937):Maintained as a working branch for additional changes on top. PR #13727 stays as the pristine "PR 13713 rebased" reference.
Status: draft, do not merge.