[None][fix] Cherry-pick PR13488 to fix ima issue#13903
Merged
lfr-0531 merged 2 commits intoNVIDIA:feat/deepseek_v4from May 9, 2026
Merged
[None][fix] Cherry-pick PR13488 to fix ima issue#13903lfr-0531 merged 2 commits intoNVIDIA:feat/deepseek_v4from
lfr-0531 merged 2 commits intoNVIDIA:feat/deepseek_v4from
Conversation
This partially reverts commit 5509617 by removing the _kv_cache.py CPU-side page-index publication guard. Keep the py_executor.py scheduling changes from that fix. Signed-off-by: Yuhang He <58161490+heyuhhh@users.noreply.github.com>
V2's StorageManager._batched_migrate() launched GPU<->host copies on a TemporaryCudaStream that only waited on per-page/per-slot ready_events. Those events can be stale or NULL'd, so the copy can start before pending forward-pass work on the execution_stream is drained. Record a fresh CachedCudaEvent on the execution_stream and add it to prior_events so TemporaryCudaStream waits for pending execution_stream work before starting the copy. This mirrors V1 syncWithBufferManager semantics. (cherry picked from commit 133f507) Signed-off-by: Yuhang He <58161490+heyuhhh@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #47409 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #47409 [ run ] completed with state |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.