Skip to content

[None][fix] Fix dis-agg with ADP and avoid TP collective deadlock#13900

Draft
Shixiaowei02 wants to merge 1 commit intoNVIDIA:feat/deepseek_v4from
Shixiaowei02:user/xiaoweis/dsv4-adp-fix
Draft

[None][fix] Fix dis-agg with ADP and avoid TP collective deadlock#13900
Shixiaowei02 wants to merge 1 commit intoNVIDIA:feat/deepseek_v4from
Shixiaowei02:user/xiaoweis/dsv4-adp-fix

Conversation

@Shixiaowei02
Copy link
Copy Markdown
Collaborator

Squashed from:

  • fix: dis-agg with ADP (77bce45)
  • update (0f50a39)
  • remove the single request type restriction (d4146f0)
  • fix: avoid TP collective deadlock (287c6f6)

@coderabbitai summary

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Squashed from:
  - fix: dis-agg with ADP (77bce45)
  - update (0f50a39)
  - remove the single request type restriction (d4146f0)
  - fix: avoid TP collective deadlock (287c6f6)

Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
@Shixiaowei02
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47381 [ run ] triggered by Bot. Commit: 60c9d81 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47381 [ run ] completed with state SUCCESS. Commit: 60c9d81
/LLM/main/L0_MergeRequest_PR pipeline #37312 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants