[None][test] Fix token throughput name to output_token_throughput#13890
[None][test] Fix token throughput name to output_token_throughput#13890fredricz-20070104 wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
📝 WalkthroughWalkthroughThe PR updates performance metric infrastructure by renaming a metric type from ChangesMetric Type Standardization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/defs/perf/test_perf.py (1)
1-1:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUpdate the file header year for this modified Python file.
Line 1 still ends at 2025, but this file is modified in 2026 and should reflect the latest modification year.
Proposed fix
-# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.As per coding guidelines: “Include NVIDIA copyright header on all new files; update year on modified files” and “All source files (.cpp, .h, .cu, .py) should contain an NVIDIA copyright header with the year of latest modification and Apache 2.0 license notice”.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/defs/perf/test_perf.py` at line 1, Update the file header line that currently reads "SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved." to reflect the latest modification year 2026, and ensure the Apache-2.0 license notice is present in the header; locate the header string in tests/integration/defs/perf/test_perf.py (the top comment) and change the year range to 2022-2026 and add or verify the accompanying Apache 2.0 license line.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@tests/integration/defs/perf/test_perf.py`:
- Line 1: Update the file header line that currently reads
"SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION &
AFFILIATES. All rights reserved." to reflect the latest modification year 2026,
and ensure the Apache-2.0 license notice is present in the header; locate the
header string in tests/integration/defs/perf/test_perf.py (the top comment) and
change the year range to 2022-2026 and add or verify the accompanying Apache 2.0
license line.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 19d43141-ae10-468d-b548-8535733840b3
📒 Files selected for processing (2)
tests/integration/defs/perf/test_perf.pytests/integration/defs/perf/utils.py
|
/bot skip --comment "only affect qa's test" |
|
|
Summary by CodeRabbit