Skip to content

Conversation

@hnover-nv
Copy link
Collaborator

@hnover-nv hnover-nv commented Jan 22, 2026

PyExecutor had variables block_reuse_enabled and enable_kv_cache_reuse that are always the same. This removes the former and switches all uses to the latter.

Test Coverage

No new tests. Should be covered by existing kv cache reuse and disagg tests.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

  • Refactor
    • Streamlined internal KV cache memory management by consolidating reuse logic, improving code maintainability and reducing unnecessary branching while preserving existing functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@hnover-nv hnover-nv requested a review from a team as a code owner January 22, 2026 20:23
@hnover-nv hnover-nv requested a review from joyang-nv January 22, 2026 20:23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 22, 2026

📝 Walkthrough

Walkthrough

Removed intermediate block_reuse_enabled flag from PyExecutor and replaced its usage with direct references to enable_kv_cache_reuse throughout initialization and control flow checks, simplifying the codebase without altering behavior.

Changes

Cohort / File(s) Summary
KV Cache Reuse Flag Simplification
tensorrt_llm/_torch/pyexecutor/py_executor.py
Removed local block_reuse_enabled variable from __init__ and replaced all references with enable_kv_cache_reuse in AsyncTransferManager initialization, _pp_retry_until_can_schedule, and _handle_responses method checks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: consolidating duplicate kv cache reuse variables in PyExecutor.
Description check ✅ Passed The PR description explains what the change does and why, identifies the test coverage strategy, and includes a completed checklist; all required elements are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hnover-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33310 [ run ] triggered by Bot. Commit: 283b61f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33310 [ run ] completed with state SUCCESS. Commit: 283b61f
/LLM/main/L0_MergeRequest_PR pipeline #25717 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@hnover-nv hnover-nv force-pushed the consolidate_kv_variable branch from 283b61f to 433471d Compare January 23, 2026 16:35
@hnover-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33396 [ run ] triggered by Bot. Commit: 433471d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33396 [ run ] completed with state SUCCESS. Commit: 433471d
/LLM/main/L0_MergeRequest_PR pipeline #25777 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@hnover-nv hnover-nv force-pushed the consolidate_kv_variable branch 2 times, most recently from f6e78bd to bf639bc Compare January 24, 2026 04:30
@hnover-nv
Copy link
Collaborator Author

/bot run --only-multi-gpu-test

@hnover-nv
Copy link
Collaborator Author

/bot kill

@hnover-nv hnover-nv force-pushed the consolidate_kv_variable branch from bf639bc to 2913ca7 Compare January 24, 2026 04:32
@hnover-nv
Copy link
Collaborator Author

/bot run --only-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33429 [ run ] triggered by Bot. Commit: 2913ca7

@litaotju litaotju requested a review from lancelly January 24, 2026 04:37
@tensorrt-cicd
Copy link
Collaborator

PR_Github #33430 [ kill ] triggered by Bot. Commit: 2913ca7

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33429 [ run ] completed with state ABORTED. Commit: 2913ca7

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33430 [ kill ] completed with state SUCCESS. Commit: 2913ca7
Successfully killed previous jobs for commit 2913ca7

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33431 [ run ] triggered by Bot. Commit: 2913ca7

Copy link
Collaborator

@lancelly lancelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33431 [ run ] completed with state SUCCESS. Commit: 2913ca7
/LLM/main/L0_MergeRequest_PR pipeline #25804 (Partly Tested) completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@hnover-nv hnover-nv force-pushed the consolidate_kv_variable branch from 2913ca7 to 3a20900 Compare January 24, 2026 20:21
@hnover-nv
Copy link
Collaborator Author

It seems likely the failures are not related to my PR, but as a new developer I want to make sure. Taylor suggested I try to get just the multi to pass, and if that happens then run the single, which makes sense.
I've had multi fail twice now but for different reasons. I'll keep rebasing and trying again, unless someone has a better suggestion.

@hnover-nv
Copy link
Collaborator Author

/bot run --only-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33454 [ run ] triggered by Bot. Commit: 3a20900

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33454 [ run ] completed with state SUCCESS. Commit: 3a20900
/LLM/main/L0_MergeRequest_PR pipeline #25824 (Partly Tested) completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Signed-off-by: Harris Nover <249353502+hnover-nv@users.noreply.github.com>
@hnover-nv hnover-nv force-pushed the consolidate_kv_variable branch from 3a20900 to 6ff9e90 Compare January 25, 2026 03:08
@hnover-nv
Copy link
Collaborator Author

/bot run --only-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33459 [ run ] triggered by Bot. Commit: 6ff9e90

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33459 [ run ] completed with state SUCCESS. Commit: 6ff9e90
/LLM/main/L0_MergeRequest_PR pipeline #25829 (Partly Tested) completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants