Skip to content

fix(bootstrap): detect docker desktop socket fallback on macos#494

Open
areporeporepo wants to merge 1 commit intoNVIDIA:mainfrom
areporeporepo:fix/bootstrap-docker-desktop-socket
Open

fix(bootstrap): detect docker desktop socket fallback on macos#494
areporeporepo wants to merge 1 commit intoNVIDIA:mainfrom
areporeporepo:fix/bootstrap-docker-desktop-socket

Conversation

@areporeporepo
Copy link

summary

this lets openshell detect docker desktop on macos when the daemon is reachable through ~/Library/Containers/com.docker.docker/Data/docker-cli.sock instead of /var/run/docker.sock.

changes

  • probe the docker desktop macos socket alongside the existing colima and orbstack fallbacks
  • retry alternative sockets before surfacing a docker preflight error when DOCKER_HOST is unset
  • add unit coverage for the docker desktop socket path

testing

  • cargo fmt --check
  • cargo build -p openshell-bootstrap
  • cargo test -p openshell-bootstrap

checklist

  • follows conventional commits
  • commits are signed off

Signed-off-by: anh nguyen <anh.nqqq@icloud.com>
Signed-off-by: areporeporepo <areporeporepo@users.noreply.github.com>
@areporeporepo areporeporepo requested a review from a team as a code owner March 20, 2026 05:51
@drew drew self-assigned this Mar 20, 2026
@drew drew added test:e2e Requires end-to-end coverage and removed test:e2e Requires end-to-end coverage labels Mar 21, 2026
@drew
Copy link
Collaborator

drew commented Mar 23, 2026

I think we're going to hold on this change for now. I don't have a great way to test it, and I'm not sure if these checks are plumbed all the way through past the pre-flight checks.

We're looking at moving to a microVM based approach, which would remove this class of bug all together.

Feel free to contribute to the discussion here, #558.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants