feat(snap): switch to prebuilt binary model to avoid copying entire r…#1651
Open
zyga wants to merge 1 commit into
Open
feat(snap): switch to prebuilt binary model to avoid copying entire r…#1651zyga wants to merge 1 commit into
zyga wants to merge 1 commit into
Conversation
…epo into LXD Switch the snapcraft build from 'source: .' (which copies the full 20 GB repo including 18 GB of target/ and build artifacts into LXD) to 'source: ./snap/prebuilt' (~130 MB of only the binaries and metadata that snapcraft needs). The snap-package workflow now downloads the same cli, gateway, and supervisor binaries that other packaging jobs (deb, rpm, tarballs) use. A new 'Prepare snap build directory' step assembles snap/prebuilt/ with the 3 binaries, gateway wrapper script, LICENSE, README.md, and a precomputed version string — everything snapcraft needs without any source tree access. This addresses CI/CD Improvements (issue NVIDIA#1361) by reducing data transferred into the LXD sandbox by ~150x and eliminating the need for snapcraft to traverse the entire repository tree. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
zyga
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
SDAChess
approved these changes
Jun 1, 2026
Collaborator
SDAChess
left a comment
SDAChess
left a comment
There was a problem hiding this comment.
Did you manage to test run the CI changes? If so then they look good to me.
Contributor
Author
|
@SDAChess not quite, the pipeline is difficult to run on my self hosted or saas infra as it currently depends on container publishing. I ran a dry run mode of this by building the binaries and placing them in the right places and running snapcraft. I think we need to give it a try and see. |
Collaborator
|
/ok-to-test ed9d470 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the snapcraft build pipeline to reuse existing binaries built earlier in the pipeline.
Related Issue
Closes #1361
Changes
Testing
mise run pre-commitpassesChecklist