chore: skills signing batch 4#4465
Conversation
|
/nvskills-ci |
📝 WalkthroughWalkthroughThis PR adds docs, reference guides, eval datasets, benchmarks, skill-cards, and signature bundles for two NemoClaw skills: remote GPU deployment (Brev, OpenClaw plugins, sandbox hardening) and sandbox monitoring/debugging, and normalizes agent-side eval JSON by removing ChangesNemoClaw Skill Documentation and Evaluation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
E2E Scenario Advisor RecommendationRequired scenario E2E: None Full scenario advisor summaryE2E Scenario AdvisorBase: Required scenario E2E
Optional scenario E2E
Relevant changed files
|
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/nemoclaw-user-deploy-remote/evals/evals.json:
- Line 34: The "question" JSON value contains a malformed phrase ("I'm the
hosted sandbox is created."); update the "question" field to use correct grammar
by replacing that fragment with a clear phrasing such as "Now that the hosted
sandbox is created, help me confirm where to connect and how to start using it
so I can move from provisioning to actual agent work." Ensure you edit the
"question" key in the JSON object to exactly use the corrected sentence.
In `@skills/nemoclaw-user-deploy-remote/evals/evals.json`:
- Line 34: The "question" string in the eval case is malformed; update the value
of the "question" key in evals.json (the JSON object containing "question") to a
grammatically correct sentence such as "The hosted sandbox is created. Help me
confirm where to connect and how to start using it so I can move from
provisioning to actual agent work." or "After the hosted sandbox is created,
help me confirm where to connect and how to start using it so I can move from
provisioning to actual agent work." ensuring proper punctuation and spacing.
In `@skills/nemoclaw-user-deploy-remote/references/brev-web-ui.md`:
- Line 101: Replace the awkward phrase "Wait for about a few minutes for pairing
to finish automatically." (the sentence in the guidance text) with a tighter
wording such as "Wait a few minutes for pairing to finish automatically." or
"Wait about a minute or two for pairing to finish automatically." to improve
readability; update the sentence exactly where it appears in the guidance
content.
In `@skills/nemoclaw-user-deploy-remote/SKILL.md`:
- Line 3: Update the metadata description string in SKILL.md to fix product-name
casing: replace lowercase occurrences of "nvidia" with "NVIDIA" and "openclaw"
with "OpenClaw", and ensure any other product tokens in that description use the
exact casing "NemoClaw" and "OpenShell" where present; edit the description
value (the string assigned to description in the diff) to perform these
substitutions so all keywords and phrases follow the project's casing rules.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3b2a1281-50b9-409a-8bf5-23636083f4b3
📒 Files selected for processing (9)
.agents/skills/nemoclaw-user-deploy-remote/evals/evals.json.agents/skills/nemoclaw-user-monitor-sandbox/evals/evals.jsonskills/nemoclaw-user-deploy-remote/SKILL.mdskills/nemoclaw-user-deploy-remote/evals/evals.jsonskills/nemoclaw-user-deploy-remote/references/brev-web-ui.mdskills/nemoclaw-user-deploy-remote/references/install-openclaw-plugins.mdskills/nemoclaw-user-deploy-remote/references/sandbox-hardening.mdskills/nemoclaw-user-monitor-sandbox/SKILL.mdskills/nemoclaw-user-monitor-sandbox/evals/evals.json
| }, | ||
| { | ||
| "id": "docs-deployment-brev-web-ui-003", | ||
| "question": "I'm the hosted sandbox is created. Help me confirm where to connect and how to start using it so I can move from provisioning to actual agent work.", |
There was a problem hiding this comment.
Mirror the eval question grammar fix here too.
Line 34 has the same malformed phrase (I'm the hosted sandbox is created.). Please apply the same corrected wording used in skills/nemoclaw-user-deploy-remote/evals/evals.json.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.agents/skills/nemoclaw-user-deploy-remote/evals/evals.json at line 34, The
"question" JSON value contains a malformed phrase ("I'm the hosted sandbox is
created."); update the "question" field to use correct grammar by replacing that
fragment with a clear phrasing such as "Now that the hosted sandbox is created,
help me confirm where to connect and how to start using it so I can move from
provisioning to actual agent work." Ensure you edit the "question" key in the
JSON object to exactly use the corrected sentence.
| }, | ||
| { | ||
| "id": "docs-deployment-brev-web-ui-003", | ||
| "question": "I'm the hosted sandbox is created. Help me confirm where to connect and how to start using it so I can move from provisioning to actual agent work.", |
There was a problem hiding this comment.
Fix malformed question text in eval case.
Line 34 should be rephrased (e.g., The hosted sandbox is created. Help me confirm... or After the hosted sandbox is created, help me confirm...).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/nemoclaw-user-deploy-remote/evals/evals.json` at line 34, The
"question" string in the eval case is malformed; update the value of the
"question" key in evals.json (the JSON object containing "question") to a
grammatically correct sentence such as "The hosted sandbox is created. Help me
confirm where to connect and how to start using it so I can move from
provisioning to actual agent work." or "After the hosted sandbox is created,
help me confirm where to connect and how to start using it so I can move from
provisioning to actual agent work." ensuring proper punctuation and spacing.
|
|
||
| The dashboard might initially show a **Pairing required** warning. | ||
| This means the gateway is still completing pairing in the background. | ||
| Wait for about a few minutes for pairing to finish automatically. Refresh the dashboard to see if the warning is resolved and the connection is established. |
There was a problem hiding this comment.
Tighten wording for readability.
Wait for about a few minutes is awkward; use either Wait a few minutes or Wait about a minute or two.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/nemoclaw-user-deploy-remote/references/brev-web-ui.md` at line 101,
Replace the awkward phrase "Wait for about a few minutes for pairing to finish
automatically." (the sentence in the guidance text) with a tighter wording such
as "Wait a few minutes for pairing to finish automatically." or "Wait about a
minute or two for pairing to finish automatically." to improve readability;
update the sentence exactly where it appears in the guidance content.
| @@ -0,0 +1,177 @@ | |||
| --- | |||
| name: "nemoclaw-user-deploy-remote" | |||
| description: "Explains how to run NemoClaw on a remote GPU instance, including the deprecated Brev compatibility path and the preferred installer plus onboard flow. Use when deploying NemoClaw to a remote VM, onboarding a Brev instance, or migrating away from the legacy `nemoclaw deploy` wrapper. Trigger keywords - deploy nemoclaw remote gpu, nemoclaw brev cloud deployment, nemoclaw plugins, openclaw plugins, install openclaw plugin, nemoclaw onboard from dockerfile, nemoclaw brev web ui, nemoclaw getting started, brev quickstart, nvidia nemotron agent, nemoclaw sandbox hardening, container security, docker capabilities, process limits." | |||
There was a problem hiding this comment.
Fix product-name casing in metadata keywords/description.
Line 3 uses nvidia and openclaw in lowercase. Please normalize to NVIDIA and OpenClaw (and keep NemoClaw/OpenShell exact casing everywhere in metadata too).
As per coding guidelines, "NVIDIA must be all caps (not Nvidia, nvidia)." and "NemoClaw, OpenClaw, and OpenShell must use correct casing."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/nemoclaw-user-deploy-remote/SKILL.md` at line 3, Update the metadata
description string in SKILL.md to fix product-name casing: replace lowercase
occurrences of "nvidia" with "NVIDIA" and "openclaw" with "OpenClaw", and ensure
any other product tokens in that description use the exact casing "NemoClaw" and
"OpenShell" where present; edit the description value (the string assigned to
description in the diff) to perform these substitutions so all keywords and
phrases follow the project's casing rules.
PR Review AdvisorFindings: 0 needs attention, 15 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/nemoclaw-user-monitor-sandbox/BENCHMARK.md`:
- Line 1: Add the required SPDX header as an HTML comment at the very top of the
BENCHMARK.md file; specifically insert an HTML comment of the form <!--
SPDX-License-Identifier: <SPDX-ID> --> (replacing <SPDX-ID> with the correct
license identifier for this repository) as the first line so the Markdown file
conforms to the project's SPDX header requirement.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 769de880-1097-4c9d-96c4-c062927a4859
📒 Files selected for processing (6)
skills/nemoclaw-user-deploy-remote/BENCHMARK.mdskills/nemoclaw-user-deploy-remote/skill-card.mdskills/nemoclaw-user-deploy-remote/skill.oms.sigskills/nemoclaw-user-monitor-sandbox/BENCHMARK.mdskills/nemoclaw-user-monitor-sandbox/skill-card.mdskills/nemoclaw-user-monitor-sandbox/skill.oms.sig
✅ Files skipped from review due to trivial changes (4)
- skills/nemoclaw-user-deploy-remote/skill-card.md
- skills/nemoclaw-user-deploy-remote/skill.oms.sig
- skills/nemoclaw-user-deploy-remote/BENCHMARK.md
- skills/nemoclaw-user-monitor-sandbox/skill-card.md
| @@ -0,0 +1,64 @@ | |||
| # Evaluation Report | |||
There was a problem hiding this comment.
Add the required SPDX header at the top of this Markdown file.
This new .md file is missing the mandatory SPDX header comment on Line 1.
Suggested fix
+<!-- SPDX-License-Identifier: Apache-2.0 -->
+
# Evaluation ReportAs per coding guidelines, "Markdown documentation files must include SPDX headers in HTML comment format".
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Evaluation Report | |
| <!-- SPDX-License-Identifier: Apache-2.0 --> | |
| # Evaluation Report |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/nemoclaw-user-monitor-sandbox/BENCHMARK.md` at line 1, Add the
required SPDX header as an HTML comment at the very top of the BENCHMARK.md
file; specifically insert an HTML comment of the form <!--
SPDX-License-Identifier: <SPDX-ID> --> (replacing <SPDX-ID> with the correct
license identifier for this repository) as the first line so the Markdown file
conforms to the project's SPDX header requirement.
Summary
Related Issue
Changes
Type of Change
Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Signed-off-by: Your Name your-email@example.com
Summary by CodeRabbit
Documentation
Tests
Benchmarks
Chores