chore: skills signing batch 3#4464
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughAdds comprehensive documentation, reference guides, evaluation datasets, benchmarks, skill-cards, and signature bundles for NemoClaw network-policy and sandbox-lifecycle skills; normalizes agent eval JSON by removing expected_behavior arrays. ChangesNemoClaw Network Policy Skill Documentation
NemoClaw Sandbox Lifecycle Skill Documentation
Evaluation Structure Normalization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
Author
|
/nvskills-ci |
Contributor
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
Contributor
E2E Scenario Advisor RecommendationRequired scenario E2E: None Full scenario advisor summaryE2E Scenario AdvisorBase: Required scenario E2E
Optional scenario E2E
Relevant changed files
|
Contributor
PR Review AdvisorFindings: 0 needs attention, 6 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/nemoclaw-user-manage-sandboxes/references/messaging-channels.md`:
- Line 102: Remove the emoji checkmark from the confirmation text examples:
replace occurrences of "✓ WeChat login confirmed" (and the duplicate at the
other location) with plain text "WeChat login confirmed" so the
messaging-channels.md examples comply with the "no emoji in technical prose"
guideline.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c8a94385-a2c9-4f9e-8c52-a6765581cccd
📒 Files selected for processing (14)
.agents/skills/nemoclaw-user-manage-policy/evals/evals.json.agents/skills/nemoclaw-user-manage-sandboxes/evals/evals.jsonskills/nemoclaw-user-manage-policy/SKILL.mdskills/nemoclaw-user-manage-policy/evals/evals.jsonskills/nemoclaw-user-manage-policy/references/approve-network-requests.mdskills/nemoclaw-user-manage-policy/references/customize-network-policy-details.mdskills/nemoclaw-user-manage-policy/references/integration-policy-examples.mdskills/nemoclaw-user-manage-sandboxes/SKILL.mdskills/nemoclaw-user-manage-sandboxes/evals/evals.jsonskills/nemoclaw-user-manage-sandboxes/references/backup-restore.mdskills/nemoclaw-user-manage-sandboxes/references/lifecycle-details.mdskills/nemoclaw-user-manage-sandboxes/references/messaging-channels.mdskills/nemoclaw-user-manage-sandboxes/references/runtime-controls.mdskills/nemoclaw-user-manage-sandboxes/references/workspace-files.md
| If you enable WeChat (experimental), the wizard does not prompt for a paste token. | ||
| Instead, it renders a QR code in your terminal, polls Tencent's iLink gateway, and captures the bot token after you scan the QR with WeChat on your phone. | ||
| The login has an eight-minute deadline, refreshes the QR up to three times on expiry, and follows iLink's IDC redirects automatically. | ||
| Keep the terminal in the foreground until you see `✓ WeChat login confirmed`. |
Contributor
There was a problem hiding this comment.
Remove emoji from confirmation text examples.
The ✓ symbol violates the Markdown docs rule forbidding emoji in technical prose. Use plain text confirmation instead.
Suggested edit
-Keep the terminal in the foreground until you see `✓ WeChat login confirmed`.
+Keep the terminal in the foreground until you see `WeChat login confirmed`.
...
-Keep the terminal in the foreground until you see `✓ WeChat login confirmed`.
+Keep the terminal in the foreground until you see `WeChat login confirmed`.Also applies to: 190-190
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/nemoclaw-user-manage-sandboxes/references/messaging-channels.md` at
line 102, Remove the emoji checkmark from the confirmation text examples:
replace occurrences of "✓ WeChat login confirmed" (and the duplicate at the
other location) with plain text "WeChat login confirmed" so the
messaging-channels.md examples comply with the "no emoji in technical prose"
guideline.
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/nemoclaw-user-manage-sandboxes/BENCHMARK.md`:
- Line 1: Add the required SPDX header as an HTML comment at the top of the
BENCHMARK.md file (above the existing "# Evaluation Report" heading) — insert a
line like <!-- SPDX-License-Identifier: MIT --> (or the correct SPDX identifier
for this project) so the document contains the SPDX header in HTML comment
format.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: af3bab56-583b-4eff-bd7d-2bd9a155c7c4
📒 Files selected for processing (6)
skills/nemoclaw-user-manage-policy/BENCHMARK.mdskills/nemoclaw-user-manage-policy/skill-card.mdskills/nemoclaw-user-manage-policy/skill.oms.sigskills/nemoclaw-user-manage-sandboxes/BENCHMARK.mdskills/nemoclaw-user-manage-sandboxes/skill-card.mdskills/nemoclaw-user-manage-sandboxes/skill.oms.sig
✅ Files skipped from review due to trivial changes (4)
- skills/nemoclaw-user-manage-sandboxes/skill-card.md
- skills/nemoclaw-user-manage-sandboxes/skill.oms.sig
- skills/nemoclaw-user-manage-policy/BENCHMARK.md
- skills/nemoclaw-user-manage-policy/skill-card.md
| @@ -0,0 +1,69 @@ | |||
| # Evaluation Report | |||
Contributor
There was a problem hiding this comment.
Add required SPDX header.
Markdown documentation files must include SPDX headers in HTML comment format. As per coding guidelines, Markdown documentation files must include SPDX headers in HTML comment format.
📝 Proposed fix to add SPDX header
+<!-- SPDX-License-Identifier: Apache-2.0 -->
+<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. -->
+
# Evaluation Report📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| # Evaluation Report | |
| <!-- SPDX-License-Identifier: Apache-2.0 --> | |
| <!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> | |
| # Evaluation Report |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/nemoclaw-user-manage-sandboxes/BENCHMARK.md` at line 1, Add the
required SPDX header as an HTML comment at the top of the BENCHMARK.md file
(above the existing "# Evaluation Report" heading) — insert a line like <!--
SPDX-License-Identifier: MIT --> (or the correct SPDX identifier for this
project) so the document contains the SPDX header in HTML comment format.
jyaunches
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Changes
Type of Change
Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Signed-off-by: Your Name your-email@example.com
Summary by CodeRabbit