refactor(cli): reduce onboard shell implementation#3919
Draft
cv wants to merge 35 commits into
Draft
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ort, function or class' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
12 tasks
| } | ||
| return null; | ||
| } | ||
| const { readLiveInference, readRecordedProvider, readRecordedNimContainer, readRecordedModel } = |
| openshellArgv, | ||
| runOpenshell, | ||
| runCaptureOpenshell, | ||
| safeOpenShellArgument, |
| return Boolean(fetchGatewayAuthTokenFromSandbox(sandboxName)); | ||
| } | ||
| const { | ||
| sandboxExistsInGateway, |
This was referenced May 21, 2026
12 tasks
This was referenced May 21, 2026
wscurran
added
NemoClaw CLI
Contributor
✨Related open PRs: Related open issues: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue the #3802 onboarding FSM cleanup by moving low-risk helper groups out of
src/lib/onboard.tsinto focused onboard modules. This keeps the live onboarding behavior unchanged while makingsrc/lib/onboard.tsmore clearly a CLI shell/orchestration layer.Related Issue
Refs #3802
Stacked on #3883
Changes
src/lib/onboard/model-router.ts.src/lib/onboard/dashboard.ts.src/lib/onboard/.src/lib/onboard.tsby more than 1,300 lines while preserving existing exports and orchestration wiring.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesmake docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com