-
Notifications
You must be signed in to change notification settings - Fork 492
Forward-merge release/1.4 into develop #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e performance and consistency (#1444) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **New Features** * Added telemetry HTTP timeout setting. * Added agent LLM controls: max token limit (16384) and a reasoning budget (1024). * Increased judge LLM token limit (16384) and updated the default judge model. * **Documentation** * Updated example configs and notebook intro to reflect new LLM settings and to note longer runtimes; removed some telemetry/tracing walkthrough content. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - https://github.com/mnajafian-nv URL: #1444
|
FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1461 +/- ##
========================================
Coverage 75.01% 75.01%
========================================
Files 553 553
Lines 38889 38890 +1
========================================
+ Hits 29172 29173 +1
Misses 9717 9717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lable (#1457) * Fix a build issue for nvidia-nat-weave using Python 3.13, currently this package attempts to install blis v0.7.11, which does not contain a pre-built wheel and fails to compile. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Chores** * CI now supports Python 3.11, 3.12, and 3.13 and will auto-install missing versions for multi-version stages. * Added automated wheel testing that builds, installs, and validates packages across each supported Python version using isolated environments. * **Bug Fixes** * Pinned a dependency to resolve build issues on Python 3.13. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - https://github.com/Salonijain27 - https://github.com/mnajafian-nv URL: #1457
Forward-merge triggered by push to release/1.4 that creates a PR to keep develop up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.