-
Notifications
You must be signed in to change notification settings - Fork 493
deps: widen fastapi version constraint for nemoguardrails compatibility #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ty. Relax the fastapi dependency from ~=0.119.0 (only 0.119.x) to >=0.115.0 to allow coexistence with nemoguardrails which requires fastapi>=0.103.0 Signed-off-by: shayanjm <shayan.mohanty@gmail.com>
WalkthroughUpdated the FastAPI dependency constraint in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "datasets~=4.4", # workaround for uv's solver choosing different versions of datasets based on sys_platform | ||
| "expandvars~=1.0", | ||
| "fastapi~=0.119.0", | ||
| "fastapi>=0.115.0", # Widened to support coexistence with nemoguardrails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "fastapi>=0.115.0", # Widened to support coexistence with nemoguardrails | |
| "fastapi~=0.119", |
This is effectively >=0.119.0,<1.0.0
I don't think we can downgrade at all
|
@shayanjm i merged a PR that relaxes several dependencies. Can you confirm if this is still an issue on |
|
Yup that works! Closing this PR now since it's resolved 😄 |
|
Thank you for bringing this to our attention! |
Description
Widen the
fastapidependency from~=0.119.0(only 0.119.x) to>=0.115.0to allowcoexistence with
nemoguardrailswhich requiresfastapi>=0.103.0.This follows the NAT's own guideline in pyproject.toml: "Keep package version constraints
as open as possible to avoid conflicts with other packages."
Closes #1449
By Submitting this PR I confirm:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.