Skip to content

Conversation

@shayanjm
Copy link

@shayanjm shayanjm commented Jan 22, 2026

Description

Widen the fastapi dependency from ~=0.119.0 (only 0.119.x) to >=0.115.0 to allow
coexistence with nemoguardrails which requires fastapi>=0.103.0.

This follows the NAT's own guideline in pyproject.toml: "Keep package version constraints
as open as possible to avoid conflicts with other packages."

Closes #1449

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Updated FastAPI dependency constraint to allow broader version compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

…ty. Relax the fastapi dependency from ~=0.119.0 (only 0.119.x) to >=0.115.0 to allow coexistence with nemoguardrails which requires fastapi>=0.103.0

Signed-off-by: shayanjm <shayan.mohanty@gmail.com>
@shayanjm shayanjm requested a review from a team as a code owner January 22, 2026 06:08
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 22, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Walkthrough

Updated the FastAPI dependency constraint in pyproject.toml from a compatible-release version specifier (~=0.119.0) to a broader minimum version constraint (>=0.115.0) to allow coexistence with NeMo Guardrails.

Changes

Cohort / File(s) Summary
Dependency Version Update
pyproject.toml
FastAPI version constraint relaxed from ~=0.119.0 to >=0.115.0 to resolve version conflict with NeMo Guardrails

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise, descriptive, uses imperative mood, and accurately summarizes the main change of widening the fastapi version constraint for nemoguardrails compatibility.
Linked Issues check ✅ Passed The PR directly addresses issue #1449 by widening the fastapi constraint from ~=0.119.0 to >=0.115.0, resolving the dependency conflict that prevented coexistence with nemoguardrails.
Out of Scope Changes check ✅ Passed The PR contains only the necessary change to resolve the linked issue; the single modification to the fastapi dependency constraint is directly scoped to the stated objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

"datasets~=4.4", # workaround for uv's solver choosing different versions of datasets based on sys_platform
"expandvars~=1.0",
"fastapi~=0.119.0",
"fastapi>=0.115.0", # Widened to support coexistence with nemoguardrails
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"fastapi>=0.115.0", # Widened to support coexistence with nemoguardrails
"fastapi~=0.119",

This is effectively >=0.119.0,<1.0.0

I don't think we can downgrade at all

@willkill07
Copy link
Member

@shayanjm i merged a PR that relaxes several dependencies. Can you confirm if this is still an issue on develop ?

@shayanjm
Copy link
Author

Yup that works! Closing this PR now since it's resolved 😄

@shayanjm shayanjm closed this Jan 23, 2026
@willkill07
Copy link
Member

Thank you for bringing this to our attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency incompatibility with NeMo Guardrails

2 participants