Add Docker Compose Support for UI + Backend Integration#24
Closed
edlee123 wants to merge 3 commits intoNVIDIA:mainfrom
Closed
Add Docker Compose Support for UI + Backend Integration#24edlee123 wants to merge 3 commits intoNVIDIA:mainfrom
edlee123 wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
…the same network as the ui
…es. Fixes also legacy ENV key value format.
mdemoret-nv
requested changes
Jul 25, 2025
Collaborator
mdemoret-nv
left a comment
There was a problem hiding this comment.
I think the Docker compose file would be better suited in the NeMo Agent Toolkit example. Otherwise this is a great addition.
Author
|
Closing this PR in favor of the PR in the main NeMo-Agent-Toolkit repo: NVIDIA/NeMo-Agent-Toolkit#497. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes Docker deployment improvements and closes Issue #23.
Key Changes
Added
compose_calculator.yamlfor a one-command deployment of the calculator example with:Updated README.md to:
Problem Addressed
Previously, a user might find connecting the UI container to a backend service via UI settings would not work. This is because Docker's default bridge network would have prevented the UI from accessing services running on the host's localhost. While it is possible to use a docker run workaround (e.g.
--network=host) to allow the UI container to access an NeMo Agent Toolkit server, this is not a production-ready approach due to security.Testing