Drop '_pg_collection' in MBridge model config when checkpointing #813
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug Fix
Overview: Bug report appeared where this was an issue, since we save our own
modelopt_run_config.yamlwhich has repr() issues. The main fix is happening in MCore'sProcessGroupCollection.__repr__, but this is a backup measure since we don't want to save it anyway, regardless. Megatron-LM does not have this issue since only M-Bridge's Model Provider classes extendTransformerConfigand store an extra_pg_collectionattribute.Usage
# Add a code snippet demonstrating how to use thisTesting
Before your PR is "Ready for review"
Additional Information
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.