Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
📝 WalkthroughWalkthroughThe GitHub Actions workflow now supports PR preview deployments alongside main documentation deployment. Pull request trigger types were expanded for lifecycle handling, permissions were modified, docs artifact upload switched from pages-specific to standard artifact upload, and a new preview deployment job using pr-preview-action was added with per-PR concurrency control. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
- Coverage 70.24% 70.23% -0.02%
==========================================
Files 227 227
Lines 25909 25909
==========================================
- Hits 18201 18198 -3
- Misses 7708 7711 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Make it much easier for reviewing changes on docs. Signed-off-by: Shengliang Xu <shengliangx@nvidia.com>
…he pages preview logic Signed-off-by: Shengliang Xu <shengliangx@nvidia.com>
86ff8bd to
8ddaec5
Compare
95ef9fa to
8ddaec5
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/pages.yml (1)
46-50: Consider skippingubuntu-setupon closed events for faster cleanup.The
ubuntu-setupaction runs even whengithub.event.action == 'closed', but it's only needed for building docs. Since the build is already skipped on closed events, you could also skip the setup step to reduce cleanup time.♻️ Proposed optimization
- uses: actions/checkout@v6 - - uses: ./.github/actions/ubuntu-setup + - uses: ./.github/actions/ubuntu-setup + if: github.event.action != 'closed' - name: Build docs if: github.event.action != 'closed' run: pip install tox && tox -e build-docs🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/pages.yml around lines 46 - 50, The ubuntu-setup action is executed unconditionally even when the Build docs step is skipped; update the workflow so the ./.github/actions/ubuntu-setup step (the step currently listed alongside actions/checkout@v6) uses the same conditional (if: github.event.action != 'closed') as the "Build docs" step to prevent running setup on closed events and speed up cleanup.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/pages.yml:
- Around line 46-50: The ubuntu-setup action is executed unconditionally even
when the Build docs step is skipped; update the workflow so the
./.github/actions/ubuntu-setup step (the step currently listed alongside
actions/checkout@v6) uses the same conditional (if: github.event.action !=
'closed') as the "Build docs" step to prevent running setup on closed events and
speed up cleanup.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d2b38d70-1346-484d-b80f-e8df58bb29f9
📒 Files selected for processing (1)
.github/workflows/pages.yml
What does this PR do?
Make a document preview for PRs
Make it much easier for reviewing changes on docs.
Summary by CodeRabbit