-
Notifications
You must be signed in to change notification settings - Fork 307
Fridah/kinjal/vllm modelopt reload #1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Fridah-nv
wants to merge
1
commit into
kinjal/vllm_modelopt_reload
Choose a base branch
from
fridah/kinjal/vllm_modelopt_reload
base: kinjal/vllm_modelopt_reload
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−11
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -60,17 +60,30 @@ lm_eval --model local-completions --tasks gsm8k --model_args model=<model_name>, | |||||||||||||||||||||
|
|
||||||||||||||||||||||
| Step 1: export the model with bf16 weights and quantizer state. To export the model: | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| - For **HF** models, use `hf_ptq_export.py`: | ||||||||||||||||||||||
| - For **HF** models, use `examples/llm_ptq/hf_ptq.py` with `--vllm_fakequant_export`: | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ```bash | ||||||||||||||||||||||
| python hf_ptq_export.py\ | ||||||||||||||||||||||
| python ../llm_ptq/hf_ptq.py \ | ||||||||||||||||||||||
| --pyt_ckpt_path <MODEL_PATH> \ | ||||||||||||||||||||||
| --quant_cfg NVFP4_DEFAULT_CFG \ | ||||||||||||||||||||||
| --qformat nvfp4 \ | ||||||||||||||||||||||
| --calib_size 512 \ | ||||||||||||||||||||||
| --export_path <EXPORT_DIR> \ | ||||||||||||||||||||||
| --vllm_fakequant_export \ | ||||||||||||||||||||||
| --trust_remote_code | ||||||||||||||||||||||
| ``` | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| This creates `<EXPORT_DIR>/vllm_fq_modelopt_state.pth` (ModelOpt quantizer state for vLLM fake-quant reload) and saves the HF-exported model under `<EXPORT_DIR>` (config/tokenizer/weights). | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| Alternatively, the dedicated `hf_ptq_export.py` script (**deprecated** — use `hf_ptq.py` with `--vllm_fakequant_export` instead) can be used for a simpler interface: | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ```bash | ||||||||||||||||||||||
| python hf_ptq_export.py \ | ||||||||||||||||||||||
| --pyt_ckpt_path <MODEL_PATH> \ | ||||||||||||||||||||||
| --quant_cfg NVFP4_DEFAULT_CFG \ | ||||||||||||||||||||||
| --export_path <EXPORT_DIR> \ | ||||||||||||||||||||||
| --trust_remote_code | ||||||||||||||||||||||
| ``` | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
|
Comment on lines
+76
to
+86
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should remove
Comment on lines
+76
to
+86
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||
| Note: `--pyt_ckpt_path` can point to either an HF checkpoint or a ModelOpt-saved checkpoint (e.g., a QAT/QAD checkpoint produced by `examples/llm_qat/main.py`). If the input checkpoint is already quantized, the script will **skip re-quantization** and only export artifacts for vLLM fakequant reload. | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| - For **MCore** models, use `modelopt.torch.export.export_mcore_gpt_to_hf_vllm_fq`: | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this to the end of arguments