security(peft): enforce torch.nn.init prefix validation#1054
Open
RinZ27 wants to merge 1 commit intoNVIDIA:mainfrom
Open
security(peft): enforce torch.nn.init prefix validation#1054RinZ27 wants to merge 1 commit intoNVIDIA:mainfrom
RinZ27 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughString-based initializers for LoRA A/B are now validated to ensure they originate from the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
Signed-off-by: RinZ27 <222222878+RinZ27@users.noreply.github.com>
b6285ba to
781fb2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix (Security)
The current implementation of allows importing arbitrary modules via configuration strings, which can lead to RCE if the config source is untrusted.
I added a strict prefix check to ensure only modules are imported, matching the docstring's intent and preventing the loading of malicious packages.
Usage
Testing
Verified the logic by ensuring that valid strings pass while arbitrary modules are rejected.
Before your PR is "Ready for review"
Additional Information
Related to security findings in automated scans.
Summary by CodeRabbit