[Feat]FakeBaseModel for offline eagle; Kimi-K2.5 fixes;#1052
[Feat]FakeBaseModel for offline eagle; Kimi-K2.5 fixes;#1052
Conversation
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip You can validate your CodeRabbit configuration file in your editor.If your editor has YAML language server, you can enable auto-completion and validation by adding |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
==========================================
+ Coverage 70.09% 70.28% +0.19%
==========================================
Files 221 227 +6
Lines 25541 25873 +332
==========================================
+ Hits 17902 18185 +283
- Misses 7639 7688 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What does this PR do?
Adds
FakeBaseModelfor offline EAGLE training and several Kimi-K2.5 compatibility fixes.FakeBaseModel— lightweight model that loads onlylm_headandembed_tokensfrom a local checkpoint, avoiding full model weight loading during offline training. Configured viaFakeBaseArgumentsand integrated intoload_vlm_or_llm._find_base_model_parts— support Kimi-K2.5 VLM layout (language_model.modelpath)past_key_value/past_key_valuesargument mismatchrglobfor.ptdiscovery in nested offline data dirs; single-node GPU count respectsCUDA_VISIBLE_DEVICESType of change: Bug fix, new feature
Testing
Tested offline EAGLE training for Kimi-K2.5 end-to-end.
Before your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: N/AAdditional Information