Conversation
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com> Co-authored-by: Kamil Tokarski <kamiltokarski04@gmail.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-of-by: Marek Dabek <mdabek@nvidia.com>
810618b to
52af0c6
Compare
|
@greptileai please review |
Greptile SummaryThis PR adds a Confidence Score: 5/5Safe to merge — all previously raised P1 issues have been resolved and only minor style findings remain. All P1 findings from prior review rounds are fixed. The two remaining findings are P2 style issues (a comment typo and a slightly inaccurate docstring) that do not affect correctness or runtime behaviour. No files require special attention.
|
| Filename | Overview |
|---|---|
| dali/python/nvidia/dali/experimental/torchvision/v2/functional/normalize.py | New functional normalize implementation; layout detection via string slicing is correct; minor comment typos ("Torchvison", "nomrlization"). |
| dali/python/nvidia/dali/experimental/torchvision/v2/normalize.py | New Normalize operator class; validation logic is correct; layout comparison uses established uint8 byte pattern; docstring slightly inaccurate about PIL Image rejection. |
| dali/test/python/torchvision/test_tv_normalize.py | Good test coverage across CPU/GPU, single/multi-channel, batch shapes, mismatched lengths, and zero-std cases. |
| dali/python/nvidia/dali/experimental/torchvision/v2/color.py | Correctly adds a non-negative guard for scalar hue before range expansion, fixing the previously flagged silent inverted-range bug. |
| dali/python/nvidia/dali/experimental/torchvision/init.py | Adds Normalize to the public torchvision API surface. |
| dali/python/nvidia/dali/experimental/torchvision/v2/functional/init.py | Exports normalize from the functional sub-package. |
| dali/python/nvidia/dali/experimental/torchvision/v2/functional/gaussian_blur.py | Whitespace-only change (blank line added before return). |
Sequence Diagram
sequenceDiagram
participant Caller
participant normalize as functional.normalize
participant _normalize as functional._normalize
participant Normalize as Normalize class
participant ndd as ndd.normalize
participant fn as fn.normalize
Caller->>normalize: normalize(input, mean, std)
normalize->>Normalize: verify_args(std, mean)
normalize->>_normalize: _normalize(input, mean, std)
_normalize->>_normalize: detect layout (CHW vs HWC)
_normalize->>_normalize: reshape mean/std arrays
_normalize->>ndd: ndd.normalize(input, mean, stddev)
ndd-->>Caller: normalized tensor
Caller->>Normalize: Normalize(mean, std)(input)
Normalize->>Normalize: verify_args (via Operator.__init__)
Normalize->>Normalize: _kernel(data_input)
Normalize->>Normalize: detect layout via property("layout")[-1]
Normalize->>fn: fn.normalize(data_input, mean, stddev)
fn-->>Caller: normalized tensor
Reviews (14): Last reviewed commit: "Typo fix" | Re-trigger Greptile
6567dda to
160ec66
Compare
|
@greptileai please re-review |
b4e11d2 to
6adc717
Compare
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
6adc717 to
64809e3
Compare
f5ac5fa to
c0f9a56
Compare
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
c0f9a56 to
e86e551
Compare
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
278022b to
d08ca9b
Compare
9f0e924 to
cb5848f
Compare
|
!build |
|
CI MESSAGE: [47913207]: BUILD STARTED |
|
CI MESSAGE: [47913207]: BUILD PASSED |
|
@greptileai please re-review |
ed8d250 to
53c08bb
Compare
Category:
New feature
Description:
Torchvision's normalize operators implementation
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A