ci: add MODEL_FAMILY and TEST_TYPE to test CONFIG blocks#2459
Closed
kajalj22 wants to merge 1 commit into
Closed
Conversation
Add structured metadata fields to every test script's CONFIG block so that nemo-ci can emit clean model_family and test_type values in test_metadata.json instead of using the full test name. - MODEL_FAMILY: canonical model identifier (e.g., qwen2.5, llama3.1) - TEST_TYPE: algorithm/task type (e.g., grpo, sft, dpo, distillation) These fields are parsed by nemo-ci's generate_rl_dynamic.sh and passed as CI variables to each test job. Non-breaking: the generator ignores unknown config keys, so older nemo-ci versions are unaffected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kajal Jain <kajalj@nvidia.com>
kajalj22
force-pushed
the
kajalj/ci-test-metadata-fields
branch
from
2b5faad to
91d53c7
Compare
Contributor
Author
|
Closing — moved to regex-based derivation in nemo-ci's generate_rl_dynamic.sh instead. No RL repo changes needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MODEL_FAMILYandTEST_TYPEfields to every test script's# ===== BEGIN CONFIG =====block (117 files)MODEL_FAMILY: canonical model identifier (e.g.,qwen2.5,llama3.1,gemma3,deepseek-v3)TEST_TYPE: algorithm/task type (e.g.,grpo,sft,dpo,distillation,dapo)Motivation
nemo-ci is adding a standardized
test_metadata.jsonartifact to every CI job (MR !2240). Themodel_familyandtest_typefields currently fall back to the full test name (e.g.,llm_sft_qwen3_0_6B_1n8g_megatron_yarn_128k) because there are no structured metadata variables in the CONFIG block. This PR adds them so nemo-ci can emit clean, queryable values.Non-breaking
generate_rl_dynamic.shin nemo-ci parses the CONFIG block withget_cfg_val()which ignores unknown keysTest plan
generate_rl_dynamic.sh(will be wired in follow-up nemo-ci MR)🤖 Generated with Claude Code