[WIP] don't review#2420
Draft
shuyixiong wants to merge 15 commits into
Draft
Conversation
github-actions
Bot
added
the
Documentation
Add the TRT-LLM PyTorch backend integration needed to validate GRPO with draft-target speculative decoding, Mongo rollout logging, and weight-sync timing on AIHub.
Remove the experimental speculative-decoding hooks (config, worker plumbing, spec_token_origins propagation, specdec exemplar config) and the MongoDB logger backend that were bundled with the TRT-LLM backend introduction. The TRT-LLM PyTorch backend itself is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
TMP commit (will amend or squash later). Layers TRT-LLM-specific wiring on top of the CUDA 13 squash from NVIDIA-NeMo#2332: - pyproject.toml: pin trtllm extra to tensorrt_llm==1.3.0rc13 - virtual_cluster.py: add PY_EXECUTABLES.TRTLLM - ray_actor_environment_registry.py: add TRTLLM_EXECUTABLE (with NEMO_RL_PY_EXECUTABLES_SYSTEM=1 fallback) - docker/Dockerfile: add SKIP_TRTLLM_BUILD arg + HPCX env exposure (cuda-compat removed — cu13.2 base image already provides it) - docs/docker.md: SKIP_TRTLLM_BUILD usage docs Known TODOs before this can be promoted: - `uv lock` likely fails: tensorrt-llm 1.3.0rc13 has no cp313 wheel. Either move trtllm to its own workspace (cp312) or relax pin. - Build + smoke test on a GB200 node not yet validated. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information