ci: Build RL main on Azure

[chtruong814]

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

• You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

• Make sure you read and followed Contributor guidelines
• Did you write any new necessary tests?
• Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
• Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

• ...

Summary by CodeRabbit

• Chores
  • Updated CI/CD workflow configuration to adjust build environment settings and container build references.

[copy-pr-bot]

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[chtruong814]

/ok to test

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated GitHub Actions workflow inputs in the CI/CD pipeline to use non-NVIDIA variable values for runner prefix, test data path, and registry. Changed the build-container workflow's build reference from a pre-flight output to a literal main branch reference.

Changes

Cohort / File(s)	Summary
GitHub Actions Workflow Configuration .github/workflows/cicd-main.yml	Modified org-member-pre-flight workflow inputs to reference vars.NON_NVIDIA_* variables instead of vars.DEFAULT_* for runner configuration and registry settings. Changed build-container workflow to use literal main branch instead of dynamically sourced test_sha output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Test Results For Major Changes	⚠️ Warning	PR contains major infrastructure changes routing CI/CD to Azure with 496 file changes but empty description and no testing documentation or validation evidence.	Revert debug changes or provide comprehensive testing documentation including Azure build success rates, performance metrics, and confirmation all NeMo RL tests pass.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title 'ci: Build RL main on Azure' is clearly related to the main change: updating CI/CD workflows to build on Azure infrastructure.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chtruong/build-azure-main

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/workflows/cicd-main.yml (1)

289-302: ⚠️ Potential issue | 🔴 Critical

Hardcoded build-ref: main breaks PR container builds.

Changing build-ref from ${{ needs.pre-flight.outputs.test_sha }} to the literal main means the container will always be built from the main branch, regardless of which PR triggered the workflow.

This creates two problems:

1. PR changes won't be tested: The container won't include code from the PR branch
2. Inconsistency with build-arg: Line 302 still uses NEMO_RL_COMMIT=${{ needs.pre-flight.outputs.test_sha }}, so the recorded commit won't match the actual code in the container

Suggested fix

-      build-ref: main
+      build-ref: ${{ needs.pre-flight.outputs.test_sha }}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/cicd-main.yml around lines 289 - 302, The workflow
hardcodes build-ref: main which prevents PR containers from being built from the
PR commit; update the uses block so build-ref uses the pre-flight output
(replace the literal "main" with ${{ needs.pre-flight.outputs.test_sha }}) to
match the NEMO_RL_COMMIT build-arg and ensure the container is built from the
same commit as the PR; verify the symbols affected are build-ref and
NEMO_RL_COMMIT in the uses: NVIDIA-NeMo/FW-CI-templates invocation so both refer
to ${{ needs.pre-flight.outputs.test_sha }} for consistency.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/cicd-main.yml:
- Around line 176-185: The workflow job org-member-pre-flight mistakenly sets
default_runner_prefix, default_test_data_path, and default_registry to the
NON_NVIDIA_* variables, which overrides the default (NVIDIA) infrastructure for
all CI runs; revert those three inputs to their intended default values (remove
assignment to NON_NVIDIA_*), or implement a safe toggle (workflow input or
separate debug workflow) so that only the non_nvidia_* inputs use the
NON_NVIDIA_* vars; ensure org-member-pre-flight continues to pass
non_nvidia_runner_prefix/non_nvidia_test_data_path/non_nvidia_registry as the
non-NVIDIA override while keeping default_* pointed to the original default
values.

---

Outside diff comments:
In @.github/workflows/cicd-main.yml:
- Around line 289-302: The workflow hardcodes build-ref: main which prevents PR
containers from being built from the PR commit; update the uses block so
build-ref uses the pre-flight output (replace the literal "main" with ${{
needs.pre-flight.outputs.test_sha }}) to match the NEMO_RL_COMMIT build-arg and
ensure the container is built from the same commit as the PR; verify the symbols
affected are build-ref and NEMO_RL_COMMIT in the uses:
NVIDIA-NeMo/FW-CI-templates invocation so both refer to ${{
needs.pre-flight.outputs.test_sha }} for consistency.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8d5c072f-e2e2-4d6e-8684-3ddfda32532a

📥 Commits

Reviewing files that changed from the base of the PR and between 71e7d71 and 133c6ae.

📒 Files selected for processing (1)

• .github/workflows/cicd-main.yml

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Debug configuration should not be merged to main.

Setting default_runner_prefix, default_test_data_path, and default_registry to NON_NVIDIA_* values makes them identical to the non-NVIDIA parameters. This forces all CI runs (including NVIDIA org members) to use Azure infrastructure, eliminating the distinction between default and non-NVIDIA paths.

Given the PR title includes "debug:", this appears to be a temporary testing configuration. If merged, this will permanently route all CI to non-NVIDIA infrastructure, which is likely unintended for production.

If this is intentional for debugging, consider:

1. Using a separate workflow file or branch for Azure testing
2. Adding a workflow input to toggle infrastructure selection
3. Reverting these changes before merging

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/cicd-main.yml around lines 176 - 185, The workflow job
org-member-pre-flight mistakenly sets default_runner_prefix,
default_test_data_path, and default_registry to the NON_NVIDIA_* variables,
which overrides the default (NVIDIA) infrastructure for all CI runs; revert
those three inputs to their intended default values (remove assignment to
NON_NVIDIA_*), or implement a safe toggle (workflow input or separate debug
workflow) so that only the non_nvidia_* inputs use the NON_NVIDIA_* vars; ensure
org-member-pre-flight continues to pass
non_nvidia_runner_prefix/non_nvidia_test_data_path/non_nvidia_registry as the
non-NVIDIA override while keeping default_* pointed to the original default
values.

[chtruong814]

/ok to test