Skip to content

fix: allow wandb config value changes on resume #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuki-97 merged 2 commits into from
Apr 1, 2026
Merged

fix: allow wandb config value changes on resume #2137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58fb411
fix: allow wandb config value changes on resume
gkaplun-nvidia Mar 22, 2026
20faf7f
test: update logger tests to expect allow_val_change=True
gkaplun-nvidia Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nemo_rl/utils/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ def log_hyperparams(self, params: Mapping[str, Any]) -> None:
Args:
params: Dict of hyperparameters to log
"""
self.run.config.update(params)
self.run.config.update(params, allow_val_change=True)

def log_plot(self, figure: plt.Figure, step: int, name: str) -> None:
"""Log a plot to wandb.
Expand Down Expand Up @@ -449,7 +449,7 @@ def log_hyperparams(self, params: Mapping[str, Any]) -> None:
Parameters:
params (Mapping[str, Any]): Mapping of hyperparameter names to values to store in the run configuration.
"""
self.run.config.update(params)
self.run.config.update(params, allow_val_change=True)

def log_plot(self, figure: plt.Figure, step: int, name: str) -> None:
"""Log a plot to swanlab.
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/utils/test_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ def test_log_hyperparams(self, mock_wandb):

# Check that config.update was called with params
mock_run = mock_wandb.init.return_value
mock_run.config.update.assert_called_once_with(params)
mock_run.config.update.assert_called_once_with(params, allow_val_change=True)


class TestSwanlabLogger:
Expand Down Expand Up @@ -476,7 +476,7 @@ def test_log_hyperparams(self, mock_swanlab):

# Check that config.update was called with params
mock_run = mock_swanlab.init.return_value
mock_run.config.update.assert_called_once_with(params)
mock_run.config.update.assert_called_once_with(params, allow_val_change=True)


class TestMLflowLogger:
Expand Down
Loading