Skip to content

Conversation

@chtruong814
Copy link
Contributor

@chtruong814 chtruong814 commented Jan 21, 2026

beep boop [🤖]: Hi @terrykong 👋,

we've cherry picked #1799 into  for you! 🚀

Please review and approve this cherry pick by your convenience!

Summary by CodeRabbit

  • Documentation
    • Introduced comprehensive model support documentation covering Hugging Face model compatibility, including LLMs and VLMs up to 70B parameters with up to 32k sequence length support, acceleration optimization methods, model examples, and performance benchmarks
    • Updated documentation navigation to include the new model support section

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Co-authored-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
@terrykong terrykong added the CI:docs Run doctest label Jan 21, 2026
@terrykong terrykong enabled auto-merge (squash) January 21, 2026 20:54
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

This pull request updates the documentation build infrastructure to use UV (Python package manager) for environment management, replacing OS-specific virtual environment handling. It also introduces a new documentation page detailing model support for Hugging Face models and updates the documentation index accordingly.

Changes

Cohort / File(s) Summary
Build Infrastructure
docs/Makefile
Replaced OS-specific VENV scaffolding with unified UV-based approach via UV_RUN; introduced check-uv validation step; updated docs HTML, publish, and live targets to use uv run for Sphinx commands; removed manual environment activation and cleanup logic.
Documentation Content
docs/about/model-support.md
New documentation page covering Hugging Face model support via NeMo AutoModel (LLMs and VLMs up to 70B parameters, 32k sequence length), NeMo Megatron-Bridge acceleration, enumerated model examples, and links to performance benchmarks and YAML recipe configs.
Documentation Index
docs/index.md
Added navigation entry for the new about/model-support page in the About section toctree.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • docs: model support page #1799: Introduces identical changes across all three modified files—UV_RUN-based documentation build targets, the same model-support.md documentation page, and matching docs/index.md navigation entry.

Suggested labels

documentation, CI:docs, r0.5.0

Suggested reviewers

  • terrykong
  • yuki-97
🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Test Results For Major Changes ⚠️ Warning PR adds 736 files with 123,805 insertions but description lacks testing information, validation details, and regression checks. Update PR description with comprehensive test results, unit test pass confirmation, functional test results, integration validation, and performance checks or link to original PR #1799.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references a cherry-pick operation (cp:) and mentions the model support page addition, which aligns with the actual changes in the PR that add documentation for model support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick CI:docs Run doctest documentation Improvements or additions to documentation Run CICD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants