-
Notifications
You must be signed in to change notification settings - Fork 223
refactor: split train and val dataset in response dataset #1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,834
−1,705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8dcf7c to
2f78c84
Compare
2f78c84 to
fd448be
Compare
2aa7ce0 to
6a093d1
Compare
terrykong
reviewed
Dec 18, 2025
Contributor
terrykong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some initial thoughts
since it's a big PR @ashors1 could you help as a second review?
examples/configs/recipes/llm/sft-llama3.1-8b-1n8g-megatron.yaml
Outdated
Show resolved
Hide resolved
yuki-97
commented
Dec 18, 2025
ashors1
reviewed
Dec 18, 2025
ashors1
reviewed
Dec 18, 2025
ashors1
reviewed
Dec 18, 2025
ashors1
reviewed
Dec 18, 2025
ashors1
reviewed
Dec 18, 2025
ashors1
reviewed
Dec 18, 2025
6b34af3 to
fea258d
Compare
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com> update all run_xxx and recipe of response dataset to use default Signed-off-by: Yuki Huang <yukih@nvidia.com> fix missing default Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
f9def0d to
ec862a3
Compare
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Contributor
Author
|
|
Signed-off-by: Yuki Huang <yukih@nvidia.com>
terrykong
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI:L1
Run doctests, unit tests, and functional tests
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1050
nemo_rl/data/datasets/response_datasets/into a similar format.clevr_cogentandopenmathinstruct2.New Param
Add a new param
split_validation_sizeto handle the case that one dataset is used for both training and validation. (e.g.,OpenMathInstruct-2inexamples/configs/grpo_math_1B.yaml)data.train.split_validation_size > 0 and data.validation is None, will use part of the training dataset as validation dataset.data.train.split_validation_size > 0 and data.validation is not None, will use both "part of the training dataset" and "provided validation dataset" as validation dataset.Usage
Migrate Guide
openai_formatandResponseDataset)Test Result
Summary by CodeRabbit
Release Notes
New Features
trainandvalidationblocks in data settingsDocumentation
Bug Fixes & Improvements
✏️ Tip: You can customize this high-level summary in your review settings.