Harden release package metadata updates#43
Merged
eric-tramel merged 1 commit intomainfrom May 8, 2026
Merged
Conversation
johnnygreco
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tighten the remaining release mechanics after the
PUBLISH=1flow landed:ddp-package-assets/packages.jsonby exact release asset id before merging package metadata;packages.jsonasset only when one was actually found;make releaseto run from the fetchedorigin/maintip, not just an older ancestor.Why
The shared package-list asset is the one mutable state point in the release process. Without concurrency, two releases published close together could both read the same old
packages.json, merge their own package files, and let the later upload drop the earlier package row. Fetching the asset by id also avoids treating anygh release downloadfailure as "no package list exists."The local release guard closes the other easy footgun: tagging an old main ancestor after forgetting to update the checkout.
Usage
The release command stays the same:
It now fails early unless the worktree is clean and
HEAD == origin/mainafter fetchingorigin main.How
concurrencyto.github/workflows/publish.ymlwithcancel-in-progress: false.gh release download ... || empty filefallback with an exact GitHub API asset lookup/download.Validation
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/publish.yml"); YAML.load_file(".github/workflows/docs.yml"); puts "workflow yaml parsed"'make -n release PLUGIN=data-designer-templatemake -n release PLUGIN=data-designer-template PUBLISH=1gh apipackage asset lookup smoke test for missing and existing assetsgit diff --checkmake checkmake docsmake lintmake test-devtools