Skip to content

Remove release owner email gate #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eric-tramel merged 1 commit into from
May 8, 2026
Merged

Remove release owner email gate #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

.PHONY: sync lint format test test-devtools test-plugins validate docs docs-server plugin-docs catalog package-index check-plugin-docs check-catalog check-package-index qa-package-index codeowners check-codeowners check-license-headers update-license-headers check all bump release build-plugin validate-release test-plugin check-owner
.PHONY: sync lint format test test-devtools test-plugins validate docs docs-server plugin-docs catalog package-index check-plugin-docs check-catalog check-package-index qa-package-index codeowners check-codeowners check-license-headers update-license-headers check all bump release build-plugin validate-release test-plugin

# ── Setup ────────────────────────────────────────────────────────────────

Expand Down Expand Up @@ -140,23 +140,7 @@ test-plugin:
build-plugin: validate-release
uv build "$(PLUGIN_DIR)" --out-dir dist/

check-owner:
@if [ -z "$(PLUGIN)" ]; then echo "ERROR: Set PLUGIN=<name>"; exit 1; fi
@USER_EMAIL=$$(git config user.email); \
OWNERS=$$(grep -v '^\s*#' "$(PLUGIN_DIR)/CODEOWNERS" | grep -v '^\s*$$' | awk '{for(i=2;i<=NF;i++) print $$i}'); \
MATCH=0; \
for owner in $$OWNERS; do \
case "$$owner" in *"$$USER_EMAIL"*) MATCH=1;; esac; \
done; \
if [ "$$MATCH" -eq 0 ]; then \
echo "WARNING: $$USER_EMAIL is not listed in $(PLUGIN_DIR)/CODEOWNERS"; \
echo "Listed owners: $$OWNERS"; \
echo ""; \
read -p "Continue anyway? (y/N) " confirm; \
[ "$$confirm" = "y" ] || [ "$$confirm" = "Y" ] || exit 1; \
fi

release: check-owner test-plugin build-plugin
release: test-plugin build-plugin
@PLUGIN_VERSION=$$(uv run python -c "import tomllib; print(tomllib.load(open('$(PLUGIN_DIR)/pyproject.toml','rb'))['project']['version'])"); \
echo "Creating tag: $(PLUGIN)/v$$PLUGIN_VERSION"; \
git tag "$(PLUGIN)/v$$PLUGIN_VERSION"; \
Expand Down
Loading