fix: Claude Code marketplace plugin structure and install docs#458
Merged
johnnygreco merged 2 commits intomainfrom Mar 25, 2026
Merged
fix: Claude Code marketplace plugin structure and install docs#458johnnygreco merged 2 commits intomainfrom
johnnygreco merged 2 commits intomainfrom
Conversation
…nstructions The plugin's SKILL.md was at the root of the plugin source directory, but Claude Code expects skills at skills/*/SKILL.md. Add a claude-plugin/ directory with a symlink to skills/ so both Claude Code marketplace and skills.sh work from the same source files. Also fix the author field in plugin.json (must be an object, not a string), rename the marketplace from nvidia-data-designer to nemo-data-designer, and update the Getting Started section of the dev notes blog post with correct install commands.
Contributor
Greptile SummaryThis PR fixes the Claude Code marketplace plugin structure for the Key changes:
|
| Filename | Overview |
|---|---|
| .claude-plugin/marketplace.json | Renames marketplace from nvidia-data-designer to nemo-data-designer and updates plugin source from ./skills/data-designer to ./claude-plugin to point to the new wrapper directory. Structurally correct. |
| claude-plugin/.claude-plugin/plugin.json | New top-level plugin wrapper descriptor for nemo-data-designer. Uses object form for author field, matching the fix applied to the leaf-level plugin.json. Plugin-name-vs-marketplace-name distinction intentional (discussed in prior review). |
| claude-plugin/skills | New symlink claude-plugin/skills → ../skills. Enables the claude-plugin/ source tree to contain the skills/data-designer leaf without duplicating files. ZIP-download limitation acknowledged and accepted in prior review thread. |
| skills/data-designer/.claude-plugin/plugin.json | Fixes author field from a bare string to the required object form {"name": "..."}. Clean one-line fix. |
| README.md | Adds a new "Agent Skill" section with correct install commands for both Claude Code marketplace and skills.sh paths, including the /reload-plugins step. |
| docs/devnotes/posts/data-designer-got-skills.md | Updates Getting Started section with corrected install commands, adds skills.sh link, /reload-plugins step, agent compatibility note, and a tip about selecting Claude Code during skills.sh installation. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Claude Code Marketplace] -->|"marketplace add NVIDIA-NeMo/DataDesigner"| B[".claude-plugin/marketplace.json\nname: nemo-data-designer"]
B -->|"source: ./claude-plugin"| C["claude-plugin/\n.claude-plugin/plugin.json\nname: nemo-data-designer"]
C -->|symlink| D["claude-plugin/skills → ../skills"]
D --> E["skills/data-designer/\n.claude-plugin/plugin.json\nname: data-designer"]
E -->|"skill discovered as"| F["/data-designer skill"]
G["skills.sh\nnpx skills add NVIDIA-NeMo/DataDesigner"] -->|"scans repo root skills/"| E
style F fill:#22c55e,color:#fff
style C fill:#3b82f6,color:#fff
style D fill:#f59e0b,color:#fff
Reviews (2): Last reviewed commit: "docs: add agent skill install section to..." | Re-trigger Greptile
johnnygreco
commented
Mar 25, 2026
Comment on lines
+113
to
+115
| ### 🤖 Agent Skill | ||
|
|
||
| Data Designer has a [skill](https://nvidia-nemo.github.io/DataDesigner/latest/devnotes/posts/data-designer-got-skills/) for coding agents. Just describe the dataset you want, and your agent handles schema design, validation, and generation. |
Contributor
Author
There was a problem hiding this comment.
seemed reasonable to add this too
andreatgretel
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-designerskill by adding aclaude-plugin/directory with a symlink toskills/, avoiding duplication while maintaining compatibility with skills.shauthorfield inplugin.json(must be an object, not a string)nvidia-data-designertonemo-data-designer/reload-pluginsstep, skills.sh link, and agent compatibility noteTest plan
Verified end-to-end locally: removed existing marketplace, re-added from local repo, installed plugin, reloaded, and confirmed
/data-designerskill is invocable.