-
Notifications
You must be signed in to change notification settings - Fork 85
chore: async engine follow-up - rename, preview, lifecycle, progress #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andreatgretel
wants to merge
16
commits into
main
Choose a base branch
from
andreatgretel/chore/async-engine-followup-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,124
−259
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
22ab0e9
chore: rename ColumnWiseDatasetBuilder, wire async preview, unify row…
andreatgretel 709f53d
feat: add consolidated async progress reporting with row group context
andreatgretel 5a7ba4c
fix async preview and progress reporting
andreatgretel 80013eb
feat: add opt-in sticky ANSI progress bars for generation
andreatgretel 16fa889
docs: add missing progress_interval docstring in RunConfig
andreatgretel 86883db
fix: update progress bar on every completion in async path
andreatgretel 324fecf
fix: resolve row-group semaphore deadlock when all tasks are deferred
andreatgretel 86ef54e
fix: eagerly salvage stalled row groups to avoid wasting semaphore slots
andreatgretel 1edacef
fix: address review findings from greptile and codex
andreatgretel 4890fa3
fix: stable progress bar width and accurate failure counts
andreatgretel f3a522f
fix: address Nabin's review - exclude_columns, dead code, docstring
andreatgretel d82c3b1
Merge branch 'main' into andreatgretel/chore/async-engine-followup-v2
andreatgretel b547216
fix: _drain_frontier exits before dispatching ready salvage tasks
andreatgretel cde30d9
fix: salvage edge cases found by code review
andreatgretel ae73275
fix: skip record_failure for already-dropped rows in salvage
andreatgretel 193f80d
Merge branch 'main' into andreatgretel/chore/async-engine-followup-v2
andreatgretel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
packages/data-designer-engine/src/data_designer/engine/context.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from contextvars import ContextVar | ||
|
|
||
| # Set by the async scheduler before executing each task. | ||
| # Value: (current_rg_index, total_rg_count) or None. | ||
| current_row_group: ContextVar[tuple[int, int] | None] = ContextVar("current_row_group", default=None) | ||
|
|
||
|
|
||
| def format_row_group_tag() -> str: | ||
| """Return a '(x/X) ' prefix if a row group context is active, else ''.""" | ||
| rg = current_row_group.get() | ||
| if rg is None: | ||
| return "" | ||
| current, total = rg[0] + 1, rg[1] | ||
| width = len(str(total)) | ||
| return f"({current:0{width}d}/{total}) " |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.