[benchmarking] Error if uv cannot be used for dumping env

[rlratzel]

• Moves code to compute session output dir to Session obj.
• Simplifies dump_env by requiring uv and will raise if it cannot be used.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[greptile-apps]

Additional Comments (1)

benchmarking/run.py, line 309
Validation will fail because Session.assert_valid_config_dict now requires "name" in config_dict (line 89 in session.py), but "name" isn't added until line 309. Move lines 308-309 before line 301.

    session_name = args.session_name or time.strftime("benchmark-run__%Y-%m-%d_%H-%M-%S_UTC")
    config_dict["name"] = session_name
    try:
        Session.assert_valid_config_dict(config_dict)
        config_dict = remove_disabled_blocks(config_dict)
        config_dict = resolve_env_vars(config_dict)
    except ValueError as e:
        logger.error(f"Invalid configuration: {e}")
        return 1

    session = Session.from_dict(config_dict, args.entries)

[praateekmahajan]

lgtm, but i can't recall why pip freeze should be run ever? recommendation for everyone is to use uv to run curator..

[greptile-apps]

Additional Comments (1)

benchmarking/runner/env_capture.py, line 45
Missing FileNotFoundError exception handling. If uv isn't installed, subprocess.check_output() raises FileNotFoundError, which isn't caught here.

    try:
        out = subprocess.check_output(cmd.split(" "), text=True, timeout=timeout)  # noqa: S603
    except FileNotFoundError:
        logger.error(f"Command '{cmd}' not found. Ensure 'uv' is installed and in PATH.")
        raise
    except subprocess.CalledProcessError as e:
        logger.error(f"Command '{cmd}' failed with exit code {e.returncode}. Environment capture failed.")
        raise
    except subprocess.TimeoutExpired:
        logger.error(f"Command '{cmd}' timed out after {timeout} seconds. Environment capture failed.")
        raise