Skip to content

Fix code review hook failing when cwd is not git root #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
malston wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −4
Open

Fix code review hook failing when cwd is not git root #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a54b282
Fix code review hook failing when cwd is not git root
malston Feb 26, 2026
f69fc9d
Revert linter formatting changes to marketplace.json
malston Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude-plugin/marketplace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"name": "automatic-code-review",
"source": "./automatic-code-review",
"description": "Automatic code review on session stop with configurable rules",
"version": "1.0.3",
"version": "1.0.4",
"category": "development",
"keywords": ["code-review", "quality", "hooks", "semantic-review"]
},
Expand Down
11 changes: 8 additions & 3 deletions automatic-code-review/hooks/tools/automatic-code-review-plugin.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ if ! command -v jq >/dev/null 2>&1; then
exit 0
fi

PROJECT_ROOT=$(git rev-parse --show-toplevel 2>/dev/null) || {
echo "ERROR: not in a git repository" >&2
exit 0
}

COMMAND="${1:-}"

if [[ -z "$COMMAND" ]]; then
Expand Down Expand Up @@ -119,13 +124,13 @@ get_modified_files() {
get_or_initialize_plugin_settings() {
local session_id="$1"

local settings_file=".claude/settings.json"
local rules_file=".claude/automatic-code-review/rules.md"
local settings_file="${PROJECT_ROOT}/.claude/settings.json"
local rules_file="${PROJECT_ROOT}/.claude/automatic-code-review/rules.md"

if [[ ! -f "$settings_file" ]] || ! jq -e '.automaticCodeReview' "$settings_file" >/dev/null 2>&1; then
local init_flag="/tmp/code-review-initialized-${session_id}"
if [[ ! -f "$init_flag" ]]; then
mkdir -p .claude/automatic-code-review
mkdir -p "${PROJECT_ROOT}/.claude/automatic-code-review"

local existing
if [[ -f "$settings_file" ]]; then
Expand Down