Fix scene edit not showing or saving HA/OpenHAB entity binding#372
Open
jamesmulcahy wants to merge 1 commit intoNSPManager:develfrom
Open
Fix scene edit not showing or saving HA/OpenHAB entity binding#372jamesmulcahy wants to merge 1 commit intoNSPManager:develfrom
jamesmulcahy wants to merge 1 commit intoNSPManager:develfrom
Conversation
When editing an existing scene, the modal only showed the name field — the Home Assistant / OpenHAB entity selector was hidden because entity_source and the items list were never passed to the template, and the save handler ignored any backend_name submitted. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
I think I'll wait to see if I need to merge this PR or not. As stated in another PR I'm currently redoing a lot of these GUI elements to use React instead as it's really a mess doing it this way. Thanks for the PR anyway. |
Contributor
Author
|
OK, understood -- will hold off on other fixes/tweaks in this area! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
entity_sourceand the items list were not passed to the templatebackend_namefrom the POST data when editing, so even if the field had been visible, the selection would not have been savedChanges
partial_entity_edit_scene_entity()now populatesentity_source,backend_name, and the relevant items list (HA or OpenHAB) so the entity selector renders with the current binding pre-selected.create_or_update_scene_entity()now updatesbackend_namewhen saving an existing HA or OpenHAB scene.Test plan
🤖 Generated with Claude Code