Skip to content

Fix clock thread spinning at midnight due to missing tm_mday increment #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesmulcahy wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Fix clock thread spinning at midnight due to missing tm_mday increment #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions docker/MQTTManager/src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,9 @@ void publish_time_and_date() {
next_minute_tm.tm_hour++;
if (next_minute_tm.tm_hour >= 24) { // We went over to next day
next_minute_tm.tm_hour = 0;

// Handle day change
if (next_minute_tm.tm_mday >= 32) { // We went over to next month
next_minute_tm.tm_mday = 1;
next_minute_tm.tm_mon++;
if (next_minute_tm.tm_mon >= 12) { // We went over to next year
next_minute_tm.tm_mon = 0;
next_minute_tm.tm_year++;
}
}
next_minute_tm.tm_mday++;
// mktime (called below) normalises month/year overflow and handles
// varying month lengths and leap years, so no manual rollover needed.
}
}

Expand Down