cosmic analysis script rewritten in numpy#34
Open
Jennefer Maldonado (jennmald) wants to merge 5 commits into
Open
cosmic analysis script rewritten in numpy#34Jennefer Maldonado (jennmald) wants to merge 5 commits into
Jennefer Maldonado (jennmald) wants to merge 5 commits into
Conversation
Jennefer Maldonado (jennmald)
requested review from
Copilot and
Daniel Henriksen (dihenriksen)
Contributor
Author
|
oh and finish documentation! |
Copilot started reviewing on behalf of
Jennefer Maldonado (jennmald)
April 27, 2026 20:37
View session
There was a problem hiding this comment.
Pull request overview
Adds a new “cosmics” analysis helper script intended to visualize and quantify cosmic-trigger-like pixels in counting detector data stored in HDF5.
Changes:
- Introduces
cosmics.pywith helpers to load HDF5 data, visualize frames, label connected components, and plot per-image count distributions. - Adds functions to detect candidate frames (
find_cosmics) and inspect data quality (check_empty,show_image,movie).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Daniel Henriksen (dihenriksen)
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on Daniel Henriksen (@dihenriksen)'s script