Skip to content

Conversation

@jessica-moylan
Copy link
Collaborator

Part of #190

Copy link
Contributor

@thopkins32 thopkins32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It would be great if you can make it testable like the other how-to-guides.

If you make it use .. testsetup::, .. testcode::, and optionally .. testoutput. Then we can test the code in the document using

pixi run doc-tests

I typically setup all of the assumptions and mock things in a hidden .. testsetup:: section at the top of the file, and then have the rest use that.

In some of them I even spin up a local tiled server:

server = SimpleTiledServer()
logging.getLogger("httpx").setLevel(logging.WARNING)
db = from_uri(server.uri)
tiled_writer = TiledWriter(db)
RE = RunEngine({})
RE.subscribe(tiled_writer)

After that it should be good to merge!

@thopkins32 thopkins32 self-requested a review December 30, 2025 21:21
Copy link
Contributor

@thopkins32 thopkins32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove the unnecessary databroker setup (you may need to remove the pinned version).

If you merge main in, I removed all of the deprecated code so it shouldn't be a problem anymore.

@thopkins32 thopkins32 merged commit 5097106 into NSLS-II:main Dec 31, 2025
9 checks passed
@jessica-moylan jessica-moylan deleted the tiled_databroker_tutorials branch December 31, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants