Skip to content

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Jan 8, 2026

Pull request overview

This is probably a WIP, haven't tried it on any platforms other than mac

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec requested a review from kbenne January 8, 2026 15:05
@jmarrec jmarrec added Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. component - Ruby bindings labels Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

🧪 Test Results Dashboard

Summary

Metric Value
Total Tests 4144
Passed 4143
Failed 1
Errors 0
Skipped 0
Success Rate 100.0%
Generated 2026-01-09 16:12:20 UTC

⚠️ Minor Issues Detected

🔍 Failed Tests (1 failures)

Linux-c++ (1 failures)

BCLFixture.BCLMeasure.BCLFixture.BCLMeasure (run3)

Error Message:

Failed

Full Details:

No details available

📊 Test Run Information

Run XML File Status
run1 results.xml ✅ Found
run3 results.xml ✅ Found
run2 results.xml ✅ Found

Copy link
Contributor

@kbenne kbenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anchapin since we don't have CI configured for any automated Modelica based tests yet, I hand built this and ran the example workflow without issue. I think this is good to go. thank you @jmarrec

@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Jan 9, 2026

@anchapin anchapin merged commit 00ea9c7 into develop Jan 9, 2026
7 checks passed
@anchapin anchapin deleted the 5574 branch January 9, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component - Ruby bindings Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing @loader_path/../lib in openstudio.bundle

6 participants