Skip to content

Add tests for precision #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AntonDevil wants to merge 3 commits into
base: master
Choose a base branch
from
+104 −0
Open

Add tests for precision #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42be969
Add precision preservation test
AntonDevil Mar 21, 2026
7207ce7
fix
AntonDevil Mar 21, 2026
9fe7e83
Merge branch 'master' into user/AntonDevil/FixRawNumberWrite
AntonDevil Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 104 additions & 0 deletions test/unittest/documenttest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,6 +728,110 @@ TEST(Document, RawNumberRoundtrip_PrettyWriter) {
EXPECT_TRUE(strstr(s, ": \"42\"") == NULL);
}

TEST(Document, RawNumberRoundtrip_Precision) {
// Numbers that would lose precision if converted to double
const char* json = "{\"big\":12345678901234567890,\"pi\":3.141592653589793238,\"tiny\":1e-14,\"tiny2\":0.00000000000001}";

Document d;
d.Parse<kParseNumbersAsStringsFlag>(json);
EXPECT_FALSE(d.HasParseError());

// Verify stored as strings internally
EXPECT_TRUE(d["big"].IsString());
EXPECT_STREQ("12345678901234567890", d["big"].GetString());
EXPECT_STREQ("3.141592653589793238", d["pi"].GetString());
EXPECT_STREQ("1e-14", d["tiny"].GetString());
EXPECT_STREQ("0.00000000000001", d["tiny2"].GetString());

// Roundtrip must preserve exact text
StringBuffer buffer;
Writer<StringBuffer> writer(buffer);
d.Accept(writer);

EXPECT_STREQ("{\"big\":12345678901234567890,\"pi\":3.141592653589793238,\"tiny\":1e-14,\"tiny2\":0.00000000000001}", buffer.GetString());
}

TEST(Document, RawNumberRoundtrip_NumberFormats) {
// Test all valid JSON number notations survive roundtrip exactly
const char* json =
"{"
"\"int\":42,"
"\"neg\":-17,"
"\"zero\":0,"
"\"frac\":3.14,"
"\"neg_frac\":-0.5,"
"\"exp_lower\":1e10,"
"\"exp_upper\":1E10,"
"\"exp_plus\":1e+10,"
"\"exp_neg\":1e-10,"
"\"exp_frac\":1.5e3,"
"\"exp_neg_frac\":2.99792458e+8,"
"\"huge_int\":99999999999999999999,"
"\"huge_neg\":-99999999999999999999,"
"\"huge_exp\":1e308,"
"\"tiny_exp\":1e-308,"
"\"tiny_frac\":0.000000000000000001,"
"\"max_digits\":1.7976931348623157e+308,"
"\"leading_zero_frac\":0.123"
"}";

Document d;
d.Parse<kParseNumbersAsStringsFlag>(json);
EXPECT_FALSE(d.HasParseError());

// Verify each value stored as exact text
EXPECT_STREQ("42", d["int"].GetString());
EXPECT_STREQ("-17", d["neg"].GetString());
EXPECT_STREQ("0", d["zero"].GetString());
EXPECT_STREQ("3.14", d["frac"].GetString());
EXPECT_STREQ("-0.5", d["neg_frac"].GetString());
EXPECT_STREQ("1e10", d["exp_lower"].GetString());
EXPECT_STREQ("1E10", d["exp_upper"].GetString());
EXPECT_STREQ("1e+10", d["exp_plus"].GetString());
EXPECT_STREQ("1e-10", d["exp_neg"].GetString());
EXPECT_STREQ("1.5e3", d["exp_frac"].GetString());
EXPECT_STREQ("2.99792458e+8", d["exp_neg_frac"].GetString());
EXPECT_STREQ("99999999999999999999", d["huge_int"].GetString());
EXPECT_STREQ("-99999999999999999999", d["huge_neg"].GetString());
EXPECT_STREQ("1e308", d["huge_exp"].GetString());
EXPECT_STREQ("1e-308", d["tiny_exp"].GetString());
EXPECT_STREQ("0.000000000000000001", d["tiny_frac"].GetString());
EXPECT_STREQ("1.7976931348623157e+308", d["max_digits"].GetString());
EXPECT_STREQ("0.123", d["leading_zero_frac"].GetString());

// Full roundtrip
StringBuffer buffer;
Writer<StringBuffer> writer(buffer);
d.Accept(writer);

// All numbers must appear unquoted and with exact original text
const char* result = buffer.GetString();
EXPECT_TRUE(strstr(result, ":42,") != NULL);
EXPECT_TRUE(strstr(result, ":-17,") != NULL);
EXPECT_TRUE(strstr(result, ":0,") != NULL);
EXPECT_TRUE(strstr(result, ":3.14,") != NULL);
EXPECT_TRUE(strstr(result, ":-0.5,") != NULL);
EXPECT_TRUE(strstr(result, ":1e10,") != NULL);
EXPECT_TRUE(strstr(result, ":1E10,") != NULL);
EXPECT_TRUE(strstr(result, ":1e+10,") != NULL);
EXPECT_TRUE(strstr(result, ":1e-10,") != NULL);
EXPECT_TRUE(strstr(result, ":1.5e3,") != NULL);
EXPECT_TRUE(strstr(result, ":2.99792458e+8,") != NULL);
EXPECT_TRUE(strstr(result, ":99999999999999999999,") != NULL);
EXPECT_TRUE(strstr(result, ":-99999999999999999999,") != NULL);
EXPECT_TRUE(strstr(result, ":1e308,") != NULL);
EXPECT_TRUE(strstr(result, ":1e-308,") != NULL);
EXPECT_TRUE(strstr(result, ":0.000000000000000001,") != NULL);
EXPECT_TRUE(strstr(result, ":1.7976931348623157e+308,") != NULL);
EXPECT_TRUE(strstr(result, ":0.123}") != NULL);

// None should be quoted
EXPECT_TRUE(strstr(result, ":\"42\"") == NULL);
EXPECT_TRUE(strstr(result, ":\"-17\"") == NULL);
EXPECT_TRUE(strstr(result, ":\"1e10\"") == NULL);
EXPECT_TRUE(strstr(result, ":\"99999999999999999999\"") == NULL);
}

#ifdef __clang__
RAPIDJSON_DIAG_POP
#endif