Update to latest snapshot + Work on GUI and Worldgen#31
Closed
ExE-Boss wants to merge 13 commits intoNOVA-Team:masterfrom
Closed
Update to latest snapshot + Work on GUI and Worldgen#31ExE-Boss wants to merge 13 commits intoNOVA-Team:masterfrom
ExE-Boss wants to merge 13 commits intoNOVA-Team:masterfrom
Conversation
10 tasks
RX14
reviewed
Jan 6, 2017
| ItemManager itemManager, | ||
| RenderManager renderManager, | ||
| NetworkManager networkManager, | ||
| RecipeManager recipeManager) { |
Contributor
There was a problem hiding this comment.
Have you imported the NOVA standard format on IDEA? Make sure you use it.
Member
Author
There was a problem hiding this comment.
The spaces being used as leading whitespace in constructors was already done like that in NovaWorldgen, I just manually copied it to the other mod classes.
Contributor
There was a problem hiding this comment.
Actually, this probably is correct. Been a while since I used the formatter.
17 tasks
Member
Author
|
Moved to #32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: NOVA-Team/NOVA-Monorepo#229, NOVA-Team/NOVA-Monorepo#231, NOVA-Team/NOVA-Monorepo#232, NOVA-Team/NOVA-Worldgen#1 and NOVA-Team/NOVA-GUI#8.
P.S.: commits: 0ec4420, de2921a and b3becb7 are the exact same commit, just some bug with GitHub for Windows caused them to be committed thrice.