WIP: re-enable mypy for pySHiELD
#82
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR re-enables
mypy(not only for the source code directory) inpyshield. It then fixes the obvious issues and leaves two things to discuss:PBLConfig, shoulddt_atmosbe of typeint(as type-hinted now) or is it supposed to be afloat(like other usage ofdt_atmoswould suggest?translate_pbl_subtestsis claiming thatpyshield.constantscontains a constant calledCDTN, where such a constant doesn't exist. Should that one be imported frompyshield.stencils.pbl.constants?@oelbert I guess you are the expert here. What do you think about the question above?
This PR is stacked on top of #81 and should be merged afterwards. This also explains the pyshield-side of failures in NOAA-GFDL/pace#173 and why we haven't seen them before.
How Has This Been Tested?
All good once CI is green.
Checklist:
See inline comments