CCM-17449: Add redirect to preview page when lockNumber conflict happens in the API#953
Open
m-salaudeen wants to merge 2 commits into
Open
Conversation
m-salaudeen
commented
May 12, 2026
| logger.error('Failed to approve template', error); | ||
|
|
||
| if (error.errorMeta?.code && error.errorMeta.code === 409) { | ||
| throw new Error('CONFLICT'); |
Contributor
Author
There was a problem hiding this comment.
I set the error to use the CONFLICT description as it defines what is being targeted which is also the error that is triggered of the lockNumber doesn't match.
…_to_letter_preview_page_if_api_validation_fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When approving a letter template, the templateId and lockNumber is sent to theAPI to validate the template is correct and the template state is the same at that point as it is when it was initially retrieved. If the lockNumber sent in this process is different from what is in the database, the approval process fails.
The target of this ticket is to redirect the user to the preview letter page so they can retry approving the letter template.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.