CCM-17502: File size check#933
Merged
Merged
Conversation
andykay-nhs
previously approved these changes
May 6, 2026
chris-elliott-nhsd
force-pushed
the
feature/CCM-17502_file-size-check
branch
2 times, most recently
from
e631ff6 to
3db10eb
Compare
andykay-nhs
reviewed
May 7, 2026
andykay-nhs
reviewed
May 7, 2026
chris-elliott-nhsd
force-pushed
the
feature/CCM-17502_file-size-check
branch
from
f92ba87 to
1a7327c
Compare
andykay-nhs
reviewed
May 7, 2026
bhansell1
reviewed
May 8, 2026
bhansell1
reviewed
May 8, 2026
bhansell1
reviewed
May 8, 2026
bhansell1
previously approved these changes
May 8, 2026
bhansell1
previously approved these changes
May 11, 2026
alexnuttall
previously approved these changes
May 11, 2026
m-salaudeen
previously approved these changes
May 11, 2026
chris-elliott-nhsd
dismissed stale reviews from m-salaudeen, alexnuttall, and bhansell1
via
ed7ef93
chris-elliott-nhsd
force-pushed
the
feature/CCM-17502_file-size-check
branch
from
b721bcc to
ed7ef93
Compare
bhansell1
approved these changes
May 12, 2026
alexnuttall
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR to add a check to ensure that uploaded letter template files are not more than 5MB. In order to avoid sending large files to nextjs server actions or over the web gateway, the way that these forms work has been changed to do as much of the validation as possible client-side. This involves creating new versions of NHSNotifyForm and NHSNotifyFormProvider that use an onSubmit handler instead of a server action.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.