Skip to content

Update stage-2-test.yaml #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timireland wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update stage-2-test.yaml #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3648d40
Update stage-2-test.yaml
timireland Apr 21, 2026
ff4c9c0
Update stage-2-test.yaml
timireland Apr 21, 2026
65812c4
Update stage-2-test.yaml
timireland Apr 21, 2026
b5cd759
Update sonar-scanner.properties
timireland Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions .github/workflows/stage-2-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,26 +200,26 @@ jobs:
name: code-coverage-report
path: .reports/lcov.info

# perform-static-analysis:
# name: "Perform static analysis"
# needs: [test-unit, merge-coverage]
# runs-on: ubuntu-latest
# permissions:
# id-token: write
# contents: read
# timeout-minutes: 5
# steps:
# - name: "Checkout code"
# uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
# with:
# fetch-depth: 0 # Full history is needed to improving relevancy of reporting
# - name: "Download coverage report for SONAR"
# uses: actions/download-artifact@v5
# with:
# name: code-coverage-report
# - name: "Perform static analysis"
# uses: NHSDigital/nhs-notify-shared-modules/.github/actions/perform-static-analysis@3.0.8
# with:
# sonar_organisation_key: "${{ vars.SONAR_ORGANISATION_KEY }}"
# sonar_project_key: "${{ vars.SONAR_PROJECT_KEY }}"
# sonar_token: "${{ secrets.SONAR_TOKEN }}"
perform-static-analysis:
name: "Perform static analysis"
needs: [test-unit, merge-coverage]
runs-on: ubuntu-latest
permissions:
id-token: write
contents: read
timeout-minutes: 5
steps:
- name: "Checkout code"
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
fetch-depth: 0 # Full history is needed to improving relevancy of reporting
- name: "Download coverage report for SONAR"
uses: actions/download-artifact@v5
with:
name: code-coverage-report
- name: "Perform static analysis"
uses: NHSDigital/nhs-notify-shared-modules/.github/actions/perform-static-analysis@3.0.8
with:
sonar_organisation_key: "${{ vars.SONAR_ORGANISATION_KEY }}"
sonar_project_key: "${{ vars.SONAR_PROJECT_KEY }}"
sonar_token: "${{ secrets.SONAR_TOKEN }}"
8 changes: 4 additions & 4 deletions scripts/config/sonar-scanner.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
sonar.host.url=https://sonarcloud.io
sonar.qualitygate.wait=true
sonar.sourceEncoding=UTF-8
sonar.sources=frontend/src/, lambdas/authorizer, lambdas/backend-api, utils/utils, data-migration/user-transfer
sonar.tests=tests/, frontend/src/__tests__, lambdas/authorizer/src/__tests__, lambdas/backend-api/src/__tests__, utils/utils/src/__tests__, data-migration/user-transfer/src/__tests__
sonar.exclusions=frontend/src/__tests__/**/*, lambdas/*/src/__tests__/**/*, data-migration/user-transfer/src/__tests__/**/*, utils/utils/src/__tests__/**/*, **/*.dev.*, frontend/src/components/forms/SubmitTemplate/SubmitLetterTemplate.tsx
sonar.sources=frontend/src/, lambdas/authorizer, lambdas/backend-api, utils/utils
sonar.tests=tests/, frontend/src/__tests__, lambdas/authorizer/src/__tests__, lambdas/backend-api/src/__tests__, utils/utils/src/__tests__
sonar.exclusions=frontend/src/__tests__/**/*, lambdas/*/src/__tests__/**/*,utils/utils/src/__tests__/**/*, **/*.dev.*, frontend/src/components/forms/SubmitTemplate/SubmitLetterTemplate.tsx
sonar.terraform.provider.aws.version=5.54.1
sonar.cpd.exclusions=**.test.*
sonar.coverage.exclusions=tests/, frontend/src/__tests__, **/*.dev.*, lambdas/**/src/__tests__, utils/utils/src/__tests__, data-migration/user-transfer/src/__tests__, utils/utils/src/zod-validators.ts ,**/jest.config.ts,scripts/**/*
sonar.coverage.exclusions=tests/, frontend/src/__tests__, **/*.dev.*, lambdas/**/src/__tests__, utils/utils/src/__tests__, utils/utils/src/zod-validators.ts, **/jest.config.ts,scripts/**/*

#sonar.python.coverage.reportPaths=.coverage/coverage.xml
sonar.javascript.lcov.reportPaths=lcov.info
Loading