Feature/ccm 17116 metrics#329
Open
nhsd-angel-pastor wants to merge 2 commits intomainfrom
Open
Conversation
nhsd-angel-pastor
force-pushed
the
feature/CCM-17116_metrics
branch
2 times, most recently
from
b285fb8 to
af7676d
Compare
…r lambdas and in python CCM-17116: Updating dependency for the events publisher in the nodejs lambdas CCM-17116: replacing console.log as its wrapped by winston CCM-17116: Adding metric for total senders CCM-17116: Rename mesh metrics CCM-17116: Updated event_publisher to include the status when recording metrics CCM-17116: Updated metrics when recording events where the status can be different between events published
nhsd-angel-pastor
force-pushed
the
feature/CCM-17116_metrics
branch
from
af7676d to
75df6cf
Compare
| ContinuationToken=continuation_token | ||
| ) | ||
|
|
||
| def list_messages(self, max_results: Optional[int] = None, workflow_filter: Optional[str] = None) -> List[str]: |
Contributor
Author
There was a problem hiding this comment.
Signature taken from https://github.com/NHSDigital/mesh-client/blob/3.2.3/mesh_client/__init__.py#L512
| self.__log.info('Polling for messages') | ||
|
|
||
| # Record how many messages are in the mailbox | ||
| remaining_messages = self.__mesh_client.list_messages() |
Contributor
Author
There was a problem hiding this comment.
using list_messages method instead of iterate_all_messages because as per documentation the iterate is slower (see https://github.com/NHSDigital/mesh-client/blob/3.2.3/mesh_client/__init__.py#L839)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To summarise, the changes are:
Updated the event publisher in typescript and in python to record the events published as a metric (see Confluence for the list of metrics )
As the event publisher now publishes metrics, it needs the dimension environment, so adding in the configuration of all the lambdas the environment name
-- Lifted the metric-handler from comms-mgr
Consolidated existing metrics namespaces into the DL metrics namespace
left as an environment variable the DL_METRICS_NAMESPACE in case we want to have a different namespace, e.g. Digital Letters/MESH, Digital Letters/PDM
Kept as it was the existing metrics with configurable name.
See comment for the tests evidences.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.