Skip to content

APPT-1712 master site list report function#1363

Merged
Dave-O-NHS merged 5 commits intomainfrom
APPT-1712-master-site-list-report
Feb 9, 2026
Merged

APPT-1712 master site list report function#1363
Dave-O-NHS merged 5 commits intomainfrom
APPT-1712-master-site-list-report

Conversation

@Dave-O-NHS
Copy link
Copy Markdown
Contributor

@Dave-O-NHS Dave-O-NHS commented Jan 28, 2026 •
edited
Loading

Description

In this PR, we are adding new function to generate "Master Site List" report, and we are also uplifting reports pages.
Both backend and frontend changes are guarded with "ReportsUplift" feature flag.

Checklist:

  • My work is behind a feature toggle (if appropriate)
  • If my work is behind a feature toggle, I've added a full suite of tests for both the ON and OFF state
  • The ticket number is in the Pull Request title, with format "APPT-XXX: My Title Here"
  • I have ran npm tsc / lint (in the future these will be ran automatically)
  • My code generates no new .NET warnings (in the future these will be treated as errors)
  • If I've added a new Function, it is disabled in all but one of the terraform groups (e.g. http_functions)
  • If I've added a new Function, it has both unit and integration tests. Any request body validators have unit tests also
  • If I've made UI changes, I've added appropriate Playwright and Jest tests
  • If I've added/updated an end-point, I've added the appropriate annotations and tested the Swagger documentation reflects the change

@Dave-O-NHS Dave-O-NHS force-pushed the APPT-1712-master-site-list-report branch 2 times, most recently from 3b407fe to 0009ee9 Compare February 2, 2026 14:35
@Dave-O-NHS Dave-O-NHS marked this pull request as ready for review February 2, 2026 14:52
@Dave-O-NHS
master site list report function
604fd4f 
added wizard to uplifted reports journey

conditionally rendering reports cards based on permissions

adding integration tests for get master site list report function

component and e2e tests for uplifted reports pages

adding postman request

removing capitalization of properties on site model
@Dave-O-NHS Dave-O-NHS force-pushed the APPT-1712-master-site-list-report branch from 02e8b18 to 604fd4f Compare February 3, 2026 10:31
pata9
pata9 reviewed Feb 5, 2026
View reviewed changes
Comment thread src/api/Nhs.Appointments.Api/Validators/MasterSiteListReportRequestValidator.cs Outdated
Comment thread src/client/src/app/lib/components/nhsuk-frontend/card.tsx Outdated
pata9
pata9 reviewed Feb 6, 2026
View reviewed changes
Comment thread src/client/src/app/reports/select/page.tsx
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 9, 2026

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
53.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Dave-O-NHS Dave-O-NHS merged commit c35bc83 into main Feb 9, 2026
3 checks passed
@Dave-O-NHS Dave-O-NHS deleted the APPT-1712-master-site-list-report branch February 9, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pata9 pata9 pata9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dave-O-NHS @pata9