Merged
Conversation
thomasleese
force-pushed
the
refactor-self-consent-tests
branch
5 times, most recently
from
a2531b2 to
c4db9b5
Compare
thomasleese
force-pushed
the
refactor-self-consent-tests
branch
from
c4db9b5 to
a6a2411
Compare
thomasleese
force-pushed
the
refactor-self-consent-tests
branch
2 times, most recently
from
a6d14d6 to
e042f0b
Compare
thomasleese
force-pushed
the
refactor-self-consent-tests
branch
6 times, most recently
from
55445fc to
0d94842
Compare
thomasleese
force-pushed
the
refactor-self-consent-tests
branch
from
0d94842 to
d5ec613
Compare
chinmaymudholkar1
approved these changes
Apr 15, 2026
thomasleese
force-pushed
the
refactor-self-consent-tests
branch
2 times, most recently
from
c6d5401 to
23c2871
Compare
This splits up the file in to two separate files, `test_parent_consent.py` and `test_self_consent.py`. This is because we'll be adding more self-consent tests and that file will get quite long. Jira-Issue: MAV-5891
To `record_parent_given_consent` to match the naming in the service itself. Jira-Issue: MAV-5891
This refactors the tests in this file to get ready for them to be more dynamic with regards to the programme. Jira-Issue: MAV-5891
This should make it easier to debug when the expected value is not found. Jira-Issue: MAV-5891
This refactors the method to make it easier to re-use elsewhere. Jira-Issue: MAV-5891
This ensures that we are testing getting consent for each programme. This is necessary as some programmes have slightly different logic. I haven't enabled MMR(V) as it's tricky to make the tests work with the current set up. Jira-Issue: MAV-5891
thomasleese
force-pushed
the
refactor-self-consent-tests
branch
from
23c2871 to
73d72d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the tests related to self-consent to make them easier to add to in the future and also to improve coverage.
Jira Issue - MAV-5891