Conversation
murugapl
force-pushed
the
follow-up-record-flow
branch
from
3a79b46 to
1f73b79
Compare
murugapl
force-pushed
the
follow-up-parent-journey
branch
from
5da8714 to
336c4a0
Compare
murugapl
force-pushed
the
follow-up-record-flow
branch
from
1f73b79 to
25cdaba
Compare
murugapl
force-pushed
the
follow-up-parent-journey
branch
from
336c4a0 to
7d2839d
Compare
murugapl
force-pushed
the
follow-up-record-flow
branch
from
25cdaba to
208b4d4
Compare
murugapl
force-pushed
the
follow-up-parent-journey
branch
from
7d2839d to
d906179
Compare
murugapl
force-pushed
the
follow-up-record-flow
branch
2 times, most recently
from
59001e4 to
5f51927
Compare
murugapl
force-pushed
the
follow-up-record-flow
branch
5 times, most recently
from
484aba2 to
a1ba06f
Compare
thomasleese
reviewed
Mar 31, 2026
jf-x-dev
reviewed
Apr 2, 2026
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| ("parent2_action", "expected_status", "expected_filter_status"), |
Collaborator
There was a problem hiding this comment.
We probably only need one of expected_status and expected_filter_status, since they are the same currently
jf-x-dev
reviewed
Apr 2, 2026
jf-x-dev
reviewed
Apr 2, 2026
| self.agree_to_flu_vaccination(consent_option) | ||
| elif programme in (Programme.MENACWY, Programme.TD_IPV): | ||
| programmes = [programme] | ||
| self.agree_to_doubles_vaccinations(*programmes) |
Collaborator
There was a problem hiding this comment.
I think we can just do self.agree_to_doubles_vaccinations(programme) here
jf-x-dev
reviewed
Apr 2, 2026
jf-x-dev
reviewed
Apr 2, 2026
murugapl
force-pushed
the
follow-up-record-flow
branch
3 times, most recently
from
f331b77 to
5dd3054
Compare
Contributor
Author
|
@jf-x-dev @thomasleese I've addressed your comments now, if you're able to have another look :) |
For some flu and mmr vaccines
The follow-up journey adds two new pages, one to confirm whether original decision stands or not, and one to confirm refusal if the original decision does stand
Verifies both parent side and nurse side MAV-3378 and MAV-526
murugapl
force-pushed
the
follow-up-record-flow
branch
from
5dd3054 to
6fda7fe
Compare
jf-x-dev
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for follow-up journey
Verifies both parent side and nurse side
MAV-3378 and MAV-526