Draft
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-0000 |
|
mfjarvis
reviewed
Apr 10, 2026
Comment on lines
+96
to
+103
| now = int(time.time()) # re-read after acquiring the lock | ||
| if ( | ||
| self._auth.cached_access_token | ||
| and self._auth.cached_access_token_expiry_time is not None | ||
| and self._auth.cached_access_token_expiry_time > now + 30 | ||
| ): | ||
| return self._auth.cached_access_token | ||
| return self._auth.get_access_token() |
Contributor
There was a problem hiding this comment.
This check is the first thing that get_access_token() does. Given we have the lock, we can just call that instead.
Suggested change
| now = int(time.time()) # re-read after acquiring the lock | |
| if ( | |
| self._auth.cached_access_token | |
| and self._auth.cached_access_token_expiry_time is not None | |
| and self._auth.cached_access_token_expiry_time > now + 30 | |
| ): | |
| return self._auth.cached_access_token | |
| return self._auth.get_access_token() | |
| return self._auth.get_access_token() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.