Conversation
|
The PR title does not conform to the required format. |
There was a problem hiding this comment.
Pull request overview
Updates the regression test GitHub Actions workflow to run the external regression test suite from a different ref, switching from a pinned version tag to the common_dev_container branch for non-prod/non-ref environments.
Changes:
- Update
REGRESSION_TEST_REPO_TAGtocommon_dev_container. - Update
REGRESSION_TEST_WORKFLOW_TAGtocommon_dev_container.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| REGRESSION_TEST_REPO_TAG="common_dev_container" # This is the tag or branch of the regression test code to run, usually a version tag like v3.1.0 or a branch name | ||
| REGRESSION_TEST_WORKFLOW_TAG="common_dev_container" # This is the tag of the github workflow to run, usually the same as REGRESSION_TEST_REPO_TAG |
There was a problem hiding this comment.
Switching REGRESSION_TEST_*_TAG from a pinned version tag (e.g. v3.9.10) to a moving branch name makes the workflow non-reproducible and introduces supply-chain risk (the fetched script can change without review). Prefer pinning to an immutable ref (release tag or commit SHA), or make this value an explicit workflow input with tight controls/auditability.
| REGRESSION_TEST_REPO_TAG="common_dev_container" # This is the tag or branch of the regression test code to run, usually a version tag like v3.1.0 or a branch name | |
| REGRESSION_TEST_WORKFLOW_TAG="common_dev_container" # This is the tag of the github workflow to run, usually the same as REGRESSION_TEST_REPO_TAG | |
| REGRESSION_TEST_REPO_TAG="v3.1.0" # This is the tag of the regression test code to run, pinned to a specific release version | |
| REGRESSION_TEST_WORKFLOW_TAG="v3.1.0" # This is the tag of the github workflow to run, usually the same as REGRESSION_TEST_REPO_TAG |
| REGRESSION_TEST_REPO_TAG="common_dev_container" # This is the tag or branch of the regression test code to run, usually a version tag like v3.1.0 or a branch name | ||
| REGRESSION_TEST_WORKFLOW_TAG="common_dev_container" # This is the tag of the github workflow to run, usually the same as REGRESSION_TEST_REPO_TAG |
There was a problem hiding this comment.
Both REGRESSION_TEST_REPO_TAG and REGRESSION_TEST_WORKFLOW_TAG are now set to the same value. If they are intended to always match, consider collapsing to a single variable to avoid drift; if they can differ, ensure downstream usage consistently uses the right variable (the branch fetch path currently uses REGRESSION_TEST_REPO_TAG regardless of REGRESSION_TEST_WORKFLOW_TAG).
| REGRESSION_TEST_REPO_TAG="common_dev_container" # This is the tag or branch of the regression test code to run, usually a version tag like v3.1.0 or a branch name | ||
| REGRESSION_TEST_WORKFLOW_TAG="common_dev_container" # This is the tag of the github workflow to run, usually the same as REGRESSION_TEST_REPO_TAG |
There was a problem hiding this comment.
PR description/title appear to still include the template instructions (e.g., “Remove this line…” and the naming guidance) and the title doesn’t follow the required Tag: [AEA-NNNN] - Short description format. Please update the PR metadata so the merge commit message/changelog are meaningful and automated versioning can tag the release correctly.
|
Summary
Remove items from this list if they are not relevant. Remove this line once this has been done
Details
Add any summary information of what is in the change. Remove this line if you have nothing to add.
Pull Request Naming
Pull requests should be named using the following format:
Tag can be one of:
Fix- for a bug fix. (Patch release)Update- either for a backwards-compatible enhancement or for a rule change that adds reported problems. (Patch release)New- implemented a new feature. (Minor release)Breaking- for a backwards-incompatible enhancement or feature. (Major release)Docs- changes to documentation only. (Patch release)Build- changes to build process only. (No release)Upgrade- for a dependency upgrade. (Patch release)Chore- for refactoring, adding tests, etc. (anything that isn't user-facing). (Patch release)If the current release is x.y.z then
Correct tagging is necessary for our automated versioning and release process.
The description of your pull request will be used as the commit message for the merge, and also be included in the changelog. Please ensure that your title is sufficiently descriptive.
Rerunning Checks
If you need to rename your pull request, you can restart the checks by either:
git commit --allow-empty -m 'trigger build' git pushRerunning the checks from within the pull request will not use the updated title.