Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5,212 changes: 2,650 additions & 2,562 deletions package-lock.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@eslint/js": "^10.0.1",
"@types/aws-lambda": "^8.10.161",
"@types/node": "^25.5.2",
"@vitest/coverage-v8": "^3.2.4",
"@vitest/coverage-v8": "^4.1.2",
"@typescript-eslint/eslint-plugin": "^8.57.2",
"@typescript-eslint/parser": "^8.57.1",
"aws-lambda": "^1.0.7",
Expand All @@ -46,7 +46,7 @@
"globals": "^17.4.0",
"ts-node": "^10.9.2",
"vite-tsconfig-paths": "^6.1.1",
"vitest": "^3.2.4",
"vitest": "^4.1.2",
"typescript": "^6.0.2",
"typescript-eslint": "^8.57.2"
},
Expand Down
10 changes: 5 additions & 5 deletions packages/cpsuLambda/src/handler.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {APIGatewayProxyResult} from "aws-lambda"
import middy from "@middy/core"
import {MiddlewareGenerator} from "./middleware"
import {MiddlewareApplicator} from "./middleware"
import {Logger} from "@aws-lambda-powertools/logger"
import {Result} from "pratica"
import {Bundle, Task} from "fhir/r4"
Expand All @@ -18,7 +18,7 @@ type EventWithHeaders = {
}
}
type HandlerConfig<Event, Message> = {
middleware: Array<MiddlewareGenerator>
middleware: Array<MiddlewareApplicator>
params: HandlerParams<Event, Message>
logger: Logger
schema?: object
Expand Down Expand Up @@ -70,10 +70,10 @@ function append_headers(headers: Record<string, string>, logger: Logger) {
* Creates a new Lambda handler with the specified handler function and middleware.
*/
export const newHandler = <Event extends EventWithHeaders, Message>(handlerConfig: HandlerConfig<Event, Message>) => {
const newHandler = middy((event: Event) => generic_handler(event, handlerConfig.params, handlerConfig.logger))
let newHandler = middy((event: Event) => generic_handler(event, handlerConfig.params, handlerConfig.logger))

for (const middleware_generator of handlerConfig.middleware) {
newHandler.use(middleware_generator(handlerConfig.logger, handlerConfig.schema))
for (const middleware_applicator of handlerConfig.middleware) {
newHandler = middleware_applicator(newHandler, handlerConfig.logger, handlerConfig.schema)
}

return newHandler
Expand Down
29 changes: 19 additions & 10 deletions packages/cpsuLambda/src/middleware.ts
Original file line number Diff line number Diff line change
@@ -1,19 +1,26 @@
import inputOutputLogger from "@middy/input-output-logger"
import httpHeaderNormalizer from "@middy/http-header-normalizer"
import {injectLambdaContext} from "@aws-lambda-powertools/logger/middleware"
import middy from "@middy/core"
import {MiddyfiedHandler} from "@middy/core"
import {APIGatewayProxyResult} from "aws-lambda"
import {Logger} from "@aws-lambda-powertools/logger"
import validator from "@middy/validator"
import {transpileSchema} from "@middy/validator/transpile"
import {validationErrorHandler} from "./errorHandler"

export type MiddlewareGenerator = (logger: Logger, schema?: object) => middy.MiddlewareObj
export type MiddlewareApplicator = <Event>(
handler: MiddyfiedHandler<Event, APIGatewayProxyResult>,
logger: Logger,
schema?: object
) => MiddyfiedHandler<Event, APIGatewayProxyResult>

export const MIDDLEWARE: Record<string, MiddlewareGenerator> = {
injectLambdaContext: (logger) => injectLambdaContext(logger, {clearState: true}),
httpHeaderNormalizer: () => httpHeaderNormalizer() as middy.MiddlewareObj,
inputOutputLogger: (logger) =>
inputOutputLogger({
export const MIDDLEWARE: Record<string, MiddlewareApplicator> = {
injectLambdaContext: (handler, logger) =>
handler.use(injectLambdaContext(logger, {clearState: true})),
httpHeaderNormalizer: (handler) =>
handler.use(httpHeaderNormalizer()),
inputOutputLogger: (handler, logger) =>
handler.use(inputOutputLogger({
logger: (request) => {
const response = (request as {response?: unknown} | null | undefined)?.response
if (response === undefined) {
Expand All @@ -22,9 +29,11 @@ export const MIDDLEWARE: Record<string, MiddlewareGenerator> = {
logger.debug("inputOutputLogger response", {response})
}
}
}),
validator: (logger, schema) => validator({eventSchema: transpileSchema(schema as object)}),
validationErrorHandler: (logger) => validationErrorHandler({logger: logger})
})),
validator: (handler, logger, schema) =>
handler.use(validator({eventSchema: transpileSchema(schema as object)})),
validationErrorHandler: (handler, logger) =>
handler.use(validationErrorHandler({logger: logger}))
}

export const DEFAULT_HANDLER_MIDDLEWARE = [
Expand Down
56 changes: 31 additions & 25 deletions packages/nhsNotifyLambda/tests/testAuth.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ describe("tokenExchange", () => {
},
sign: vi.fn().mockImplementation(() => Promise.resolve("signed.jwt.token"))
}
mockSignJWTConstructor.mockImplementation(() => fakeJwtInstance)
mockSignJWTConstructor.mockImplementation(function() {
return fakeJwtInstance
})

// Mock the HTTP call
nock(`${host}`)
Expand Down Expand Up @@ -101,18 +103,20 @@ describe("tokenExchange", () => {
}

mockImportPKCS8.mockImplementation(() => Promise.resolve("imported"))
mockSignJWTConstructor.mockImplementation(() => ({
setProtectedHeader() {
return this
},
setIssuedAt() {
return this
},
setExpirationTime() {
return this
},
sign: vi.fn().mockImplementation(() => Promise.resolve("jwt-tkn"))
}))
mockSignJWTConstructor.mockImplementation(function() {
return ({
setProtectedHeader() {
return this
},
setIssuedAt() {
return this
},
setExpirationTime() {
return this
},
sign: vi.fn().mockImplementation(() => Promise.resolve("jwt-tkn"))
})
})

nock(`${host}`)
.post("/oauth2/token")
Expand All @@ -131,18 +135,20 @@ describe("tokenExchange", () => {
}

mockImportPKCS8.mockImplementation(() => Promise.resolve("imported"))
mockSignJWTConstructor.mockImplementation(() => ({
setProtectedHeader() {
return this
},
setIssuedAt() {
return this
},
setExpirationTime() {
return this
},
sign: vi.fn().mockImplementation(() => Promise.resolve("jwt-tkn"))
}))
mockSignJWTConstructor.mockImplementation(function() {
return ({
setProtectedHeader() {
return this
},
setIssuedAt() {
return this
},
setExpirationTime() {
return this
},
sign: vi.fn().mockImplementation(() => Promise.resolve("jwt-tkn"))
})
})

nock(`${host}`)
.post("/oauth2/token")
Expand Down
6 changes: 3 additions & 3 deletions packages/nhsNotifyLambda/tests/testHelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ vi.mock("@aws-sdk/client-sqs", async (importOriginal) => {
const sqs = await importOriginal<typeof import("@aws-sdk/client-sqs")>()
return {
...sqs,
SQSClient: vi.fn().mockImplementation(() => ({
send: mockSend
}))
SQSClient: vi.fn(class {
send = mockSend
})
}
})

Expand Down
10 changes: 5 additions & 5 deletions packages/nhsNotifyLambda/tests/testNhsNotifyLambda.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ vi.mock(
"@aws-lambda-powertools/logger",
async () => ({
__esModule: true,
Logger: vi.fn().mockImplementation(() => ({
info: mockInfo,
error: mockError,
warn: mockWarn
}))
Logger: vi.fn(class {
info = mockInfo
error = mockError
warn = mockWarn
})
})
)

Expand Down
6 changes: 3 additions & 3 deletions packages/nhsNotifyLambda/tests/testUtils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ vi.mock(
"@aws-lambda-powertools/parameters/ssm",
async () => ({
__esModule: true,
SSMProvider: vi.fn().mockImplementation(() => ({
getParametersByName: mockGetParametersByName
}))
SSMProvider: vi.fn(class {
getParametersByName = mockGetParametersByName
})
})
)

Expand Down
6 changes: 3 additions & 3 deletions packages/postDatedLambda/tests/testDatabaseClient.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ vi.mock("@aws-sdk/client-dynamodb", async () => {
const dynamo = await vi.importActual<typeof import("@aws-sdk/client-dynamodb")>("@aws-sdk/client-dynamodb")
return {
...dynamo,
DynamoDBClient: vi.fn().mockImplementation(() => ({
send: mockSend
}))
DynamoDBClient: vi.fn(class {
send = mockSend
})
}
})
const {
Expand Down
6 changes: 3 additions & 3 deletions packages/postDatedLambda/tests/testSqs.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ vi.mock("@aws-sdk/client-sqs", async () => {
const sqs = await vi.importActual<typeof import("@aws-sdk/client-sqs")>("@aws-sdk/client-sqs")
return {
...sqs,
SQSClient: vi.fn().mockImplementation(() => ({
send: mockSend
}))
SQSClient: vi.fn(class {
send = mockSend
})
}
})

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ vi.mock(
const mod = await importOriginal()
return {
...mod,
DynamoDBClient: vi.fn().mockImplementation(() => ({send: mockSend}))
DynamoDBClient: vi.fn(class {
send = mockSend
})
}
}
)
Expand Down
4 changes: 3 additions & 1 deletion packages/updatePrescriptionStatus/tests/testHandler.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ vi.mock("@aws-sdk/client-dynamodb", async (importOriginal) => {
const mod = await importOriginal<typeof import("@aws-sdk/client-dynamodb")>()
return {
...mod,
DynamoDBClient: vi.fn().mockImplementation(() => ({send: dynamoDBMockSend}))
DynamoDBClient: vi.fn(class {
send = dynamoDBMockSend
})
}
})

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ vi.mock("@aws-sdk/client-dynamodb", async (importOriginal) => {
const mod = await importOriginal<typeof import("@aws-sdk/client-dynamodb")>()
return {
...mod,
DynamoDBClient: vi.fn().mockImplementation(() => ({send: mockSend}))
DynamoDBClient: vi.fn(class {
send = mockSend
})
}
})

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ vi.mock("@aws-sdk/client-sqs", async (importOriginal: () => Promise<typeof impor
const mod = await importOriginal()
return {
...mod,
SQSClient: vi.fn().mockImplementation(() => ({send: mockSend}))
SQSClient: vi.fn(class {
send = mockSend
})
}
})

Expand Down
Loading